qt: Redesign of the main toolbar #3554
Conversation
This allows setting a size policy for the toolbar buttons so that they are stretched over the toolbar and resize on window size changes.
This also removes the blue logo because its not longer used.
xdustinface
force-pushed
the
pr-ui-1-toolbar
branch
from
b743bec to
7dee671
Compare
|
This looks fantastic! What a difference! Just one question, has this been tested under Windows 10 with a HiDPI display panel and scaling enabled? See #3311 and #3344 and let me know if you want me to do any testing on my hardware, since I have had scaling and/or blurriness problems for several versions now. |
Thanks!
Kind if yeah. Its developed on macOS (with retina display) and i also tested with windows/linux in a VM. Tried a bit with the scaling because i had those two issue in mind but still, the more different testing environments the better, so sure, please do your tests 🙂 Related to the blurriness you will still find issues probably at least on splashscreen and the address in the QR code image. Its on my list to investigate though! |
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Just one suggestion, otherwise looks good 👍
|
Sure, there is nothing could say against keeping the old styles there 😄 Added the suggestions + removed the blue background from the label, re-added the blue logo with a higher resolution and put it into the traditional toolbars logo label. Looks like:
|
|
A few notes after testing on native HiDPI Windows 10:
In general I find that even when using the scaling sliders, it is impossible to get the same size and weight of the font in the menu bar. So the application always feels like it "sticks out" and goes against the grain of other Windows apps because the text is a different size, weight, font and scaling than every other app on my computer. Is it possible to get an option to just use the system settings for everything, so it feels more "native"? |
|
@strophy your comment looks unrelated to this specific PR. I created a separate issue to make sure it's not lost after this PR is merged. Pls move the discussion about these and other issues there (or to specific PRs) instead. |
* qt: Replaced QAction with QToolButton for BitcoinGUI toolbar buttons. This allows setting a size policy for the toolbar buttons so that they are stretched over the toolbar and resize on window size changes. * qt: Give the BitcoinGUI's toolbar more style * qt: Give the toolbar logo a higher resolution This also removes the blue logo because its not longer used. * qt: Restore the traditional themes toolbar previous styles and logo
* qt: Replaced QAction with QToolButton for BitcoinGUI toolbar buttons. This allows setting a size policy for the toolbar buttons so that they are stretched over the toolbar and resize on window size changes. * qt: Give the BitcoinGUI's toolbar more style * qt: Give the toolbar logo a higher resolution This also removes the blue logo because its not longer used. * qt: Restore the traditional themes toolbar previous styles and logo
4 participants
This PR ist part of a series of +-25 PRs related to UI redesigns. Its ancestor is #3508, its successor is #3555. I did not screenshot every single PR and its changes, instead i made "walk through all screen" videos with the result of this PR series and also with the 0.15 UI. If there are any concrete screenshots wanted, just let me know. To build with the full set of changes you can build from the branch xdustinface:pr-ui-redesign which always contains all changes.
-> Walk through 0.15
-> Walk through Redesign
I tried to give the commits enough text to make things obvious without a lot description for each PR. Also here, if you want more description for this specific PR, let me know.
About this PR
This PR gives the toolbar state related styles/colors and stretches its buttons over the window's width. It also brings a dash logo with higher resolution to the toolbar.
All PRs are based on its ancestor. Click here to see the changes of this PR only