Fix argument handling for devnets #3549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise one would have to use "dev.port=123" in configs, which might be confusing as we usually name such networks "devnet".
-devnet is not a boolean arg, but a string. So we have to check for existence only.
codablock
added a commit
to codablock/dash
that referenced
this pull request
Jun 24, 2020
* Use "devnet" instead of "dev" for network id Otherwise one would have to use "dev.port=123" in configs, which might be confusing as we usually name such networks "devnet". * Fix ArgsManager::GetChainName to work with devnets again -devnet is not a boolean arg, but a string. So we have to check for existence only.
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jul 1, 2021
* Use "devnet" instead of "dev" for network id Otherwise one would have to use "dev.port=123" in configs, which might be confusing as we usually name such networks "devnet". * Fix ArgsManager::GetChainName to work with devnets again -devnet is not a boolean arg, but a string. So we have to check for existence only.
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Feb 22, 2022
* Use "devnet" instead of "dev" for network id Otherwise one would have to use "dev.port=123" in configs, which might be confusing as we usually name such networks "devnet". * Fix ArgsManager::GetChainName to work with devnets again -devnet is not a boolean arg, but a string. So we have to check for existence only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting bitcoin#11862 has broken
-devnet=devnetname, which is fixed by this PR.