Skip to content

Merge #12836: Make WalletInitInterface and DummyWalletInit private, f… #3498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UdjinM6 merged 1 commit into from
May 20, 2020
Merged

Merge #12836: Make WalletInitInterface and DummyWalletInit private, f… #3498

UdjinM6 merged 1 commit into from
May 20, 2020

Conversation

@PastaPastaPasta
Copy link
Member

@PastaPastaPasta PastaPastaPasta commented May 20, 2020

fixes #3497

@laanwj @PastaPastaPasta
Merge bitcoin#12836: Make WalletInitInterface and DummyWalletInit pri…
2acf2a0 
…vate, fix nullptr deref

d894894 wallet: Refactor to WalletInitInterface* const g_wallet_init_interface (João Barbosa)
39bc2fa wallet: Make WalletInitInterface and DummyWalletInit private (João Barbosa)

Pull request description:

  Implementations of `WalletInitInterface` don't have to be public, so make them private. This makes the interface instantiation static. Also reduces `ENABLE_WALLET` usage and removes the unnecessary `src/wallet/init.h` header.

Tree-SHA512: 203c49d8c85252d1bd0ff1d7ed8bcdc842d12d2d396e965cc70be5c8159a62e98ec23d32d2f3dc48a53e575844130d0a7dedac3cc2fe4621d31319b7a1c9ba89
Signed-off-by: pasta <[email protected]>

# Conflicts:
#	src/qt/dash.cpp
#	src/wallet/init.cpp
#	src/wallet/init.h
#	src/walletinitinterface.h
@PastaPastaPasta PastaPastaPasta added this to the 16 milestone May 20, 2020
UdjinM6
UdjinM6 approved these changes May 20, 2020
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@UdjinM6 UdjinM6 merged commit 0662f17 into dashpay:develop May 20, 2020
@PastaPastaPasta PastaPastaPasta deleted the backport-12836 branch May 20, 2020 16:08
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 12, 2022
@PastaPastaPasta @laanwj @gades
Merge bitcoin#12836: Make WalletInitInterface and DummyWalletInit pri…
b5a7b4b 
…vate, fix nullptr deref (dashpay#3498)

d894894 wallet: Refactor to WalletInitInterface* const g_wallet_init_interface (João Barbosa)
39bc2fa wallet: Make WalletInitInterface and DummyWalletInit private (João Barbosa)

Pull request description:

  Implementations of `WalletInitInterface` don't have to be public, so make them private. This makes the interface instantiation static. Also reduces `ENABLE_WALLET` usage and removes the unnecessary `src/wallet/init.h` header.

Tree-SHA512: 203c49d8c85252d1bd0ff1d7ed8bcdc842d12d2d396e965cc70be5c8159a62e98ec23d32d2f3dc48a53e575844130d0a7dedac3cc2fe4621d31319b7a1c9ba89
Signed-off-by: pasta <[email protected]>

Co-authored-by: Wladimir J. van der Laan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

16

Development

Successfully merging this pull request may close these issues.

3 participants

@PastaPastaPasta @UdjinM6 @laanwj