Allow txindex to be off in full mode #3484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pasta <[email protected]>
UdjinM6
requested changes
May 15, 2020
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
nACK
Disabling txindex breaks Governance. Such nodes won't be able to validate gobject collaterals and will ban other nodes which sent them these messages. As a result they will also reject triggers and superblocks and fork off/stuck eventually, see discussion in #1743.
Signed-off-by: Pasta <[email protected]>
Member
Author
Member
Author
|
Superseded by #3488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally made this change to see how stuff would break... But then I had a problem... Nothing broke!
I'm not sure if the break if actually much deeper, and I just don't see everything breaking, but this change allowed me to start a wallet, with txindex off. When I did so, I expected IS to crash the wallet or something, but it... didn't... IS worked... Chainlocks worked... I think this is a result of the implementation of LLMQ based IS. Under the old IS model, individual inputs received locks, whereas in the new model (If I recall / read the code correctly) the entire tx gets locked. So whereas in the old system, you needed txindex when receiving IS, now you don't.
This also has the added benefit of allowing people to run pruned nodes which have all of Dash's lovely features like privatesend, instantsend and chainlocks enabled automagically
(Assuming everything is good in this PR) Regarding whether to merge into 0.16 or 0.17 I don't have much of a preference, ofc since it is my change I am going to want to see it in 16, however, this isn't a bug fix, and would likely cause more testing to be needed. Basically emotionally I want it in 16, but logically I think it should probably be after 16