Merge bitcoin#10762: [wallet] Remove Wallet dependencies from init.cpp #3412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
rebased on develop |
PastaPastaPasta
force-pushed
the
backport-10762
branch
from
737ce27 to
2858dc4
Compare
c7ec524 [wallet] Add dummy wallet init class (John Newbery) 49baa4a [wallet] Use global g_wallet_init_interface to init/destroy the wallet. (John Newbery) caaf972 [wallet] Create wallet init interface. (John Newbery) 5fb5421 [wallet] Move wallet init functions into WalletInit class. (John Newbery) Pull request description: This continues the work of bitcoin#7965. This PR, along with several others, would remove the remaining dependencies from libbitcoin_server.a on libbitcoin_wallet.a. To create the interface, I've just translated all the old init.cpp wallet function calls into an interface class. I've not done any thinking about whether it makes sense to change that interface by combining/splitting those calls. This is a purely internal interface, so there's no problem in changing it later. Tree-SHA512: 32ea57615229c33fd1a7f2f29ebc11bf30337685f7211baffa899823ef74b65dcbf068289c557a161c5afffb51fdc38a2ee8180720371f64d433b12b0615cf3f Signed-off-by: Pasta <[email protected]> # Conflicts: # src/dashd.cpp # src/init.cpp
Signed-off-by: Pasta <[email protected]>
Signed-off-by: Pasta <[email protected]>
Signed-off-by: Pasta <[email protected]>
Signed-off-by: Pasta <[email protected]>
Signed-off-by: Pasta <[email protected]>
Signed-off-by: Pasta <[email protected]>
Signed-off-by: Pasta <[email protected]>
Signed-off-by: Pasta <[email protected]>
UdjinM6
requested changes
Apr 16, 2020
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Proposed changes:
- Should backup wallets before trying to verify them. This is because
-salvagewalletis very dangerous and can actually corrupt wallets making them irreparably broken. - No reason to make
schedulePrivateSendClientMaintenancea part of the wallet (interface) becauseprivateSendClientis a global object not tied to the wallet directly atm. - Should not run client-side mixing on masternodes.
- Fix
InitAutoBackupsignature inDummyWalletInit.
Pls see 823eac5e8b
Changes: - Should backup wallets before trying to verify them. This is because `-salvagewallet` is very dangerous and can actually corrupt wallets making them irreparably broken. - No reason to make `schedulePrivateSendClientMaintenance` a part of the wallet (interface) because `privateSendClient` is a global object not tied to the wallet directly atm. - Should not run client-side mixing on masternodes. - Fix `InitAutoBackup` signature in `DummyWalletInit`.
Member
Author
|
Done, left two comments on your commit, tests pass |
Signed-off-by: pasta <[email protected]>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Feb 14, 2022
dashpay#3412) * Merge bitcoin#10762: [wallet] Remove Wallet dependencies from init.cpp c7ec524 [wallet] Add dummy wallet init class (John Newbery) 49baa4a [wallet] Use global g_wallet_init_interface to init/destroy the wallet. (John Newbery) caaf972 [wallet] Create wallet init interface. (John Newbery) 5fb5421 [wallet] Move wallet init functions into WalletInit class. (John Newbery) Pull request description: This continues the work of bitcoin#7965. This PR, along with several others, would remove the remaining dependencies from libbitcoin_server.a on libbitcoin_wallet.a. To create the interface, I've just translated all the old init.cpp wallet function calls into an interface class. I've not done any thinking about whether it makes sense to change that interface by combining/splitting those calls. This is a purely internal interface, so there's no problem in changing it later. Tree-SHA512: 32ea57615229c33fd1a7f2f29ebc11bf30337685f7211baffa899823ef74b65dcbf068289c557a161c5afffb51fdc38a2ee8180720371f64d433b12b0615cf3f Signed-off-by: Pasta <[email protected]> * a couple of fixes Signed-off-by: Pasta <[email protected]> * move privatesend launch options help into wallet/init.cpp Signed-off-by: Pasta <[email protected]> * remove ENABLE_WALLET for AutoLockMasternodeCollaterals Signed-off-by: Pasta <[email protected]> * move a wallet param interaction into wallet/init.cpp Signed-off-by: Pasta <[email protected]> * move PrivateSend init to wallet/init.h Signed-off-by: Pasta <[email protected]> * move privatesend scheduler into wallet.cpp Signed-off-by: Pasta <[email protected]> * remove unneeded import Signed-off-by: Pasta <[email protected]> * move KeePass init and InitAutoBackup into wallet/init.cpp Signed-off-by: Pasta <[email protected]> * Fix 10762 Changes: - Should backup wallets before trying to verify them. This is because `-salvagewallet` is very dangerous and can actually corrupt wallets making them irreparably broken. - No reason to make `schedulePrivateSendClientMaintenance` a part of the wallet (interface) because `privateSendClient` is a global object not tied to the wallet directly atm. - Should not run client-side mixing on masternodes. - Fix `InitAutoBackup` signature in `DummyWalletInit`. * remove boost dependancy in wallet/init.cpp Signed-off-by: pasta <[email protected]> Co-authored-by: Wladimir J. van der Laan <[email protected]> Co-authored-by: UdjinM6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dependency for bitcoin#10740 which I am planning on backporting into 0.16 as it seems to be one of the more requested features