Merge bitcoin#13151: net: Serve blocks directly from disk when possible #3408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PastaPastaPasta
commented
Apr 12, 2020
Member
Author
|
Dropped those two functions, so I think it'd be safe to see we won't see the large speed-ups that upstream did? |
PastaPastaPasta
changed the title
PastaPastaPasta
force-pushed
the
backport-13151
branch
from
c949c73 to
5e3d838
Compare
Member
Author
|
rebased on develop |
UdjinM6
requested changes
Apr 16, 2020
|
Needs rebase |
PastaPastaPasta
force-pushed
the
backport-13151
branch
from
bb6c659 to
8663b28
Compare
Member
Author
|
rebased on develop |
0bf4318 net: Serve blocks directly from disk when possible (Wladimir J. van der Laan) Pull request description: In `ProcessGetBlockData`, send the block data directly from disk if type MSG_WITNESS_BLOCK is requested. This is a valid shortcut as the on-disk format matches the network format. This is expected to increase performance because a deserialization and subsequent serialization roundtrip is avoided. Tree-SHA512: 9a9500b4c1354eaae1a6f1c6ef2416c1c1985029852589266f3a70e808f6c7482c135e9ab251a527566935378ab7c32dba4ed43ba5451e802d8e72b77d1ba472 Signed-off-by: Pasta <[email protected]> # Conflicts: # src/net_processing.cpp # src/validation.cpp
Signed-off-by: Pasta <[email protected]>
Signed-off-by: Pasta <[email protected]>
PastaPastaPasta
force-pushed
the
backport-13151
branch
from
8663b28 to
ec06a89
Compare
Member
Author
|
rebased again to hopefully resolve tests |
Signed-off-by: Pasta <[email protected]>
PastaPastaPasta
force-pushed
the
backport-13151
branch
from
ec06a89 to
b179fb6
Compare
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Feb 10, 2022
…le (dashpay#3408) * Merge bitcoin#13151: net: Serve blocks directly from disk when possible 0bf4318 net: Serve blocks directly from disk when possible (Wladimir J. van der Laan) Pull request description: In `ProcessGetBlockData`, send the block data directly from disk if type MSG_WITNESS_BLOCK is requested. This is a valid shortcut as the on-disk format matches the network format. This is expected to increase performance because a deserialization and subsequent serialization roundtrip is avoided. Tree-SHA512: 9a9500b4c1354eaae1a6f1c6ef2416c1c1985029852589266f3a70e808f6c7482c135e9ab251a527566935378ab7c32dba4ed43ba5451e802d8e72b77d1ba472 Signed-off-by: Pasta <[email protected]> # Conflicts: # src/net_processing.cpp # src/validation.cpp * fix extra bracket Signed-off-by: Pasta <[email protected]> * remove read raw block from disk functions Signed-off-by: Pasta <[email protected]> * correct `if (pblock)` scope Signed-off-by: Pasta <[email protected]> Co-authored-by: Wladimir J. van der Laan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.