Merge #11648: [tests] Add messages.py #3372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
requested changes
Mar 27, 2020
There was a problem hiding this comment.
nit: this was re-ordered alphabetically in the original PR, should probably do the same to minimize potential merge conflicts in the future
…arate module I manually recreated this commit, since we have A LOT of conflicts in mininode. However since it is primarily just a move, it was pretty easy to recreate Signed-off-by: Pasta <[email protected]>
Mostly move only. Adds a few extra comments.
Signed-off-by: Pasta <[email protected]>
Signed-off-by: Pasta <[email protected]>
Signed-off-by: Pasta <[email protected]>
PastaPastaPasta
force-pushed
the
backport-11648
branch
from
ff4ae3a to
ed26ba9
Compare
Member
Author
|
force pushed rebasing on develop and fixing conflicts caused by adding devnets to mininode |
Signed-off-by: pasta <[email protected]>
Signed-off-by: pasta <[email protected]>
Signed-off-by: pasta <[email protected]>
|
Looks like some messages are/were missing fb77e3a634 |
Member
Author
|
done |
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 30, 2021
* [tests] Tidy up mininode.py module Mostly move only. Adds a few extra comments. * bitcoin#11648 [tests] Move test_framework Bitcoin primitives into separate module I manually recreated this commit, since we have A LOT of conflicts in mininode. However since it is primarily just a move, it was pretty easy to recreate Signed-off-by: Pasta <[email protected]> * add import to messages.py Signed-off-by: Pasta <[email protected]> * move import from mininode.py to messages.py Signed-off-by: Pasta <[email protected]> * fix test failure Signed-off-by: Pasta <[email protected]> * remove empty line at top of messages.py Signed-off-by: pasta <[email protected]> * alphabetize MESSAGEMAP seperated by if it is dash specific or not Signed-off-by: pasta <[email protected]> * remove accidentally added feefilter message Signed-off-by: pasta <[email protected]> * Add missing getmnlistd/mnlistdiff messages to MESSAGEMAP Co-authored-by: John Newbery <[email protected]> Co-authored-by: UdjinM6 <[email protected]>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Feb 21, 2022
* [tests] Tidy up mininode.py module Mostly move only. Adds a few extra comments. * bitcoin#11648 [tests] Move test_framework Bitcoin primitives into separate module I manually recreated this commit, since we have A LOT of conflicts in mininode. However since it is primarily just a move, it was pretty easy to recreate Signed-off-by: Pasta <[email protected]> * add import to messages.py Signed-off-by: Pasta <[email protected]> * move import from mininode.py to messages.py Signed-off-by: Pasta <[email protected]> * fix test failure Signed-off-by: Pasta <[email protected]> * remove empty line at top of messages.py Signed-off-by: pasta <[email protected]> * alphabetize MESSAGEMAP seperated by if it is dash specific or not Signed-off-by: pasta <[email protected]> * remove accidentally added feefilter message Signed-off-by: pasta <[email protected]> * Add missing getmnlistd/mnlistdiff messages to MESSAGEMAP Co-authored-by: John Newbery <[email protected]> Co-authored-by: UdjinM6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.