Skip to content

Conversation

@codablock
Copy link

This is a preparation for future PRs which will require that the quorum connection handling is able to swap out the set of connections after a specific (new) spork is activated.

@codablock codablock added this to the 16 milestone Mar 20, 2020
@codablock codablock force-pushed the pr_refactor_llmq_conns branch from daba391 to 0102032 Compare March 20, 2020 16:16
nmarley
nmarley previously approved these changes Mar 21, 2020
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor

utACK

UdjinM6
UdjinM6 previously approved these changes Mar 24, 2020
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Instead of only doing it the first time. This is a preparation for
the new intra-quorum connection system (which connects all members to all
other members)
@codablock codablock dismissed stale reviews from UdjinM6 and nmarley via 7f1f1d1 March 24, 2020 09:58
@codablock codablock force-pushed the pr_refactor_llmq_conns branch from 0102032 to 7f1f1d1 Compare March 24, 2020 09:58
@codablock
Copy link
Author

Had to rebase on develop to fix conflicts. Need re-ACK

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@codablock codablock merged commit 94bcf85 into dashpay:develop Mar 24, 2020
@codablock codablock deleted the pr_refactor_llmq_conns branch March 24, 2020 10:20
panleone pushed a commit to panleone/PIVX that referenced this pull request Nov 15, 2024
Fuzzbawls added a commit to PIVX-Project/PIVX that referenced this pull request Jan 11, 2025
a85b450 Merge pull request dashpay#3399 from codablock/pr_speedups2 (Alexander Block)
136f900 cherry-pick dashpay#2833 (Alexander Block)
d942439 Merge pull request dashpay#3389 from codablock/pr_concentrated_recovery (Alexander Block)
36790d2 cherry pick dashpay#3368 (Author Alexander Block)
dac01a9 cherry-pick dashpay#2780 (Alexander Block)
39d0ed9 cherry-pick dashpay#3367 (Alexander Block)
5084bbf Allow re-signing of IS locks when performing retroactive signing (dashpay#3219) (Alexander Block)
802c006 Only track last seen time instead of first and last seen time (dashpay#3165) (Alexander Block)
479b64b Avoid propagating InstantSend related old recovered sigs (dashpay#3145) (Alexander Block)
27fa2af cherry-pick dashpay#3117 (Pasta)
cf138e0 cherry-pick dashpay#3097 (Pasta)
23b140e Introduce getbestchainlock rpc and fix llmq-is-cl-conflicts.py (dashpay#3094) (UdjinM6)

Pull request description:

  as usual each commit backports a different PR

ACKs for top commit: a85b450
  Duddino:
    utACK a85b450
  Liquid369:
    uTACK a85b450
  Fuzzbawls:
    ACK a85b450

Tree-SHA512: e9024d180888d8a6cc300ba9df74fc15929e3ade1773e5d312bd8cc93f6c9fd3898c5bf2d14672abf4faba576575c33936708e6e1dfd01a393479d264d3f2c57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants