Skip to content

Conversation

@riordant
Copy link

@riordant riordant commented Mar 4, 2020

Fixed upstream on Bitcoin (bitcoin#16387)

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting. However this looks like an incomplete backport of at least bitcoin#14123 and bitcoin#16720. We try to avoid patching like that and prefer clean backports (ideally without skipping any intermediary PRs unless they are focused on things like segwit, rbf etc.) because otherwise we'd have to resolve lots of merge conflicts in the future and it becomes a huge mess very quickly.

So yes, it's a good idea to backport fixes and make it compilable on Catalina but not this way.

nACK

PS. if you decide to change this to a "clean" version I described above, pls also rebase it on top of develop (and select correct branch in Github UI) because master is a stable branch in Dash Core (unlike in Bitcoin Core) and all fixes should go into develop only.

@UdjinM6
Copy link

UdjinM6 commented Apr 30, 2020

Superseded by #3463

@UdjinM6 UdjinM6 closed this Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants