Backport bitcoin#11817: [tests] Change feature_csv_activation.py to use BitcoinTestFramework #3278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
force-pushed
the
pr_backport_11817
branch
from
75f303a to
d03e09a
Compare
Makes the test a lot clearer.
codablock
force-pushed
the
pr_backport_11817
branch
from
d03e09a to
13b4a92
Compare
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Feb 22, 2022
…se BitcoinTestFramework (dashpay#3278) * [tests] fix flake8 nits in feature_csv_activation.py * [tests] improve logging in feature_csv_activation.py * [tests] Remove nested loops from feature_csv_activation.py Makes the test a lot clearer. * [tests] Move utility functions in feature_csv_activation.py out of class. * [tests] Change feature_csv_activation.py to use BitcoinTestFramework * Few import fixes Co-authored-by: John Newbery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports bitcoin#11817 with the same reasoning as in #3277