Backport bitcoin#16254 and remove hires theme #3217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
099e4b9 Set AA_EnableHighDpiScaling attribute early (Hennadii Stepanov) Pull request description: Running `bitcoin-qt` compiled against Qt 5.12.4 causes a warning: ``` hebasto@bionic-qt:~/bitcoin$ src/qt/bitcoin-qt Attribute Qt::AA_EnableHighDpiScaling must be set before QCoreApplication is created. ``` This PR fixes this issue. From Qt docs: - [Qt::AA_EnableHighDpiScaling](https://doc.qt.io/qt-5/qt.html#ApplicationAttribute-enum): > Enables high-DPI scaling in Qt on supported platforms (see also High DPI Displays). _Supported platforms are X11, Windows and Android._ Enabling makes Qt scale the main (device independent) coordinate system according to display scale factors provided by the operating system. This corresponds to setting the `QT_AUTO_SCREEN_SCALE_FACTOR` environment variable to 1. This attribute must be set before `QGuiApplication` is constructed. This value was added in Qt 5.6. - [QCoreApplication::setAttribute()](https://doc.qt.io/qt-5/qcoreapplication.html#setAttribute) ACKs for commit 099e4b: MarcoFalke: ACK 099e4b9 jonasschnelli: utACK 099e4b9 fanquake: ACK 099e4b9. Did some testing on `Bionic` and `Windows 10` (using VirtualBox). I couldn't see any obvious visual difference, but given Marco's screens above, this change is obviously better. I also checked that there wasn't any sort of regression on macOS. Tree-SHA512: 1965a427ee14ffb3871bac317685032406cf02d1fa2b2dc11c8b643bfe4ba09195674d149d1e41752f14c0d000446b35e142f3ce60d987ba97082fd7ee39a094
UdjinM6
approved these changes
Nov 22, 2019
Author
|
@jhodges10 can you maybe test this PR and confirm that it looks fine on HiRes? |
nmarley
approved these changes
Nov 22, 2019
nmarley
left a comment
nmarley
left a comment
There was a problem hiding this comment.
Looks the same for me on normal resolution
slightly tested ACK
UdjinM6
added a commit
to UdjinM6/dash
that referenced
this pull request
Nov 22, 2019
UdjinM6
added a commit
to UdjinM6/dash
that referenced
this pull request
Nov 22, 2019
UdjinM6
added a commit
that referenced
this pull request
Nov 22, 2019
* Copy light(-hires).css -> dark(-hires).css (with no changes yet) * Add dark(-hires).css to makefile/qrc and show them in theme selector * Dark theme (css part) * Do not style unit selector in status bar via platform styles, use css instead * No coloring via forms (*.ui) * Implement and use helpers to style parts of rich text differently for light and dark themes * Remove dark-hires due to #3217 * Revert changes to light-hires.css to avoid merge conflicts with #3217
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
* Copy light(-hires).css -> dark(-hires).css (with no changes yet) * Add dark(-hires).css to makefile/qrc and show them in theme selector * Dark theme (css part) * Do not style unit selector in status bar via platform styles, use css instead * No coloring via forms (*.ui) * Implement and use helpers to style parts of rich text differently for light and dark themes * Remove dark-hires due to dashpay#3217 * Revert changes to light-hires.css to avoid merge conflicts with dashpay#3217 Signed-off-by: cevap <[email protected]>
cryptolinux
pushed a commit
to cryptolinux/ion
that referenced
this pull request
Feb 6, 2021
* Copy light(-hires).css -> dark(-hires).css (with no changes yet) * Add dark(-hires).css to makefile/qrc and show them in theme selector * Dark theme (css part) * Do not style unit selector in status bar via platform styles, use css instead * No coloring via forms (*.ui) * Implement and use helpers to style parts of rich text differently for light and dark themes * Remove dark-hires due to dashpay#3217 * Revert changes to light-hires.css to avoid merge conflicts with dashpay#3217 Signed-off-by: cevap <[email protected]>
ckti
pushed a commit
to ckti-gitian-ion/ion
that referenced
this pull request
Mar 29, 2021
* Copy light(-hires).css -> dark(-hires).css (with no changes yet) * Add dark(-hires).css to makefile/qrc and show them in theme selector * Dark theme (css part) * Do not style unit selector in status bar via platform styles, use css instead * No coloring via forms (*.ui) * Implement and use helpers to style parts of rich text differently for light and dark themes * Remove dark-hires due to dashpay#3217 * Revert changes to light-hires.css to avoid merge conflicts with dashpay#3217 Signed-off-by: cevap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting bitcoin#16254 fixes Qt's HiRes support, which was meant to be enabled since a long time already. But due to
Qt::AA_EnableHighDpiScalingbeing enabled after the instantiation ofBitcoinApplication, this never actually worked.Fixing this also allows us to remove the hires theme, as the normal themes already work perfectly fine on a HiDpi monitor now.