Handle transaction status updates in GUI caused by islocks and chainlocks on a per-tx basis #3152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
force-pushed
the
fixslowguihugewallets
branch
from
46cdcb8 to
200c75f
Compare
|
Hmm, it looks like the way the need for status updates is handled with IS locks was flawed from day one (f8f1435). With this type of check we would update all TXs even if just a single one has changed the IS lock status. Here is an alternative implementation: I did not test this as I'm not sure that I'd be able to reproduce the slowliness you've seen. |
Instead of updating every transaction when a lock comes in for any transaction, we should only update the affected transaction.
UdjinM6
force-pushed
the
fixslowguihugewallets
branch
from
200c75f to
a0a7831
Compare
UdjinM6
changed the title
Author
|
Applied your patches, extracted |
Author
|
Closing in fav of #3155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.