Fix chia_bls include prefix #3091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partially fixes #3090 |
PastaPastaPasta
approved these changes
Sep 16, 2019
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
travis fails, seems unrelated, utACK
nmarley
added a commit
to nmarley/dash
that referenced
this pull request
Oct 4, 2019
nmarley
added a commit
to nmarley/dash
that referenced
this pull request
Nov 21, 2019
nmarley
added a commit
to nmarley/dash
that referenced
this pull request
Dec 7, 2019
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jan 14, 2020
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try and build chia_bls dependency in Alpine linux, the compiler can't find the path to the
gmp.hheader:I am assuming this can be found in
<staging-dir>/<host-triplet>but not sure why this is working in Ubuntu but not on Alpine. For some reason it's not finding the gmp header directly indash/depends/<host-triplet>.This patch allows the compiler to find the header files and build the chia_bls dependency.