Skip to content

Use chainparams factory for devnet #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UdjinM6 merged 1 commit into from
Sep 17, 2019
Merged

Use chainparams factory for devnet #3087

UdjinM6 merged 1 commit into from
Sep 17, 2019

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Sep 12, 2019

Fixes an issue introduced in 5065267

@UdjinM6 UdjinM6 added this to the 14.1 milestone Sep 12, 2019
thephez
thephez reviewed Sep 12, 2019
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly-tested ACK (starts without a core dump)

PastaPastaPasta
PastaPastaPasta approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

nmarley
nmarley approved these changes Sep 16, 2019
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 mentioned this pull request Sep 16, 2019
Merged
@UdjinM6 UdjinM6 merged commit 0d126c2 into dashpay:develop Sep 17, 2019
codablock
codablock reviewed Sep 22, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post merge utACK

@UdjinM6 UdjinM6 deleted the fixdevnet branch November 26, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thephez thephez thephez left review comments

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

+2 more reviewers

@codablock codablock codablock left review comments

@nmarley nmarley nmarley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

15

Development

Successfully merging this pull request may close these issues.

5 participants

@UdjinM6 @nmarley @codablock @PastaPastaPasta @thephez