Backports 0.15 pr7 #2727

PastaPastaPasta · 2019-02-26T22:53:26Z

No description provided.

…lied to unsigned type) 8e0720b Fix msvc compiler error C4146 (unary minus operator applied to unsigned type) (kobake) 292112f Fix msvc compiler error C4146 (minus operator applied to unsigned type) (kobake) Tree-SHA512: 25f408daf7bf9ffe4b8b4bd62f6f6d326219189a9faf8f8c0a135c5a0cb0511af765aa2b6087a091c8863c701289bda49a2379b00cd9b10854d316a5c3fc3f8e

…inter (thread_specific_ptr) 53a2ba3 [util] Remove redundant call to get() on smart pointer (thread_specific_ptr) (practicalswift) Tree-SHA512: ec8ace4218ae0657d1aaf8ba7682b0cdd140fe0844173058d3cbf4575dee8d9ad5f241e5bacf1e9e4ad3f7dd282f56a8cb0f306de2093f2c0f6333daedd58261

9ea2490 [trival] Fix typo introduced into rpc/protocol.h in commit 338bf06 (practicalswift) Tree-SHA512: bfa60dc9f40db867b09e60dbe803db79c86ff939048c91e551c0794a91428bde3aa42c4aabf915c640cd15565005608da10dae051942e806fdf5d28e9704d765

64c0800 Use logging in individual tests (John Newbery) 38ad281 Use logging in test_framework/comptool.py (John Newbery) ff19073 Use logging in test_framework/blockstore.py (John Newbery) 2a9c7c7 Use logging in test_framework/util.py (John Newbery) b0dec4a Remove manual debug settings in qa tests. (John Newbery) af1363c Always enable debug log and microsecond logging for test nodes. (John Newbery) 6d0e325 Use logging in mininode.py (John Newbery) 553a976 Add logging to p2p-segwit.py (John Newbery) 0e6d23d Add logging to test_framework.py (John Newbery) Tree-SHA512: 42ee2acbf444ec32d796f930f9f6e272da03c75e93d974a126d4ea9b2dbaa77cc57ab5e63ce3fd33d609049d884eb8d9f65272c08922d10f8db69d4a60ad05a3

d055bd6 Fix extended rpc tests broken by 8910b47 (John Newbery) Tree-SHA512: 30e019bd7e17013143e419777491ac0efd9760dddac7232d320c9afe80bc2fb383acd331e20cd5b3e21df1177c0e4a5221c99f831e90cf869d3affca206b9728

dcf2112 Add safe flag to listunspent result (NicolasDorier) af61d9f Add COutput::fSafe member for safe handling of unconfirmed outputs (Russell Yanofsky) Tree-SHA512: 311edb6fa8075b3ede5b24cb8c6e5d133ccd8ac9ecafea07b604ffa812ee4f071337e31695e662d8573590a0460af20aaaeb39d49c9ea87924449ea50bdfb0b3

09fe2d9 release: update docs to show basic codesigning procedure (Cory Fields) f642753 release: create a bundle for the new signing script (Cory Fields) 0068361 release: add win detached sig creator and our cert chain (Cory Fields) Tree-SHA512: 032ad84697c70faaf857b9187f548282722cffca95d658e36413dc048ff02d9183253373254ffcc1158afb71140753f35abfc9fc8781ea5329c04d13c98759c0

…e-SHA512, point travis to different keyservers df5bae2 Update trusted-sha512-root-commit for new bad tree hash (Matt Corallo) efc06c2 If GNU sha512sum is missing, try perl shasum in verify-commits (Matt Corallo) 8ed849f Fix travis failing to fetch keys from the sks keyserver pool (Matt Corallo) fd5e905 Make verify-commits.sh non-recursive (Matt Corallo) Tree-SHA512: 457cc81d6e0a77ab32d030ecd058c59857f22cb998a1394593e115639081f3fdc74a6376035b77be0712ad5cb9143bc3f498b77e99eb66034492dbbb38c39bc6

…it, instead of worktree a327e8e devtools: Make github-merge compute SHA512 from git, instead of worktree (Wladimir J. van der Laan) Tree-SHA512: 22ec7712876be4ab361015a2dd75a09628ec59105ffe3260126f899d8f3ff8666351b65b9a4dfe83f78eb777730442cd0352b155d7f573424f7fc1c4dbc0ddd2

…e >0 fee tx 655df06 QA: getblocktemplate_longpoll.py should always use >0 fee tx (Suhas Daftuar) Tree-SHA512: 016647ba1408f8aaa3fc954835542354d54bf2391c4252c1c505101edbbe1cf8dd6a07060930109d0341f86360b9391dfef439999a93a5bae68fc901dace0b71

4d51e9b Assert ConnectBlock block and pIndex are the same block (NicolasDorier) 972714c pow: GetNextWorkRequired never called with NULL pindexLast (Daniel Cousens) cc44c8f ContextualCheckBlockHeader should never have pindexPrev to NULL (NicolasDorier) Tree-SHA512: 7cc568bf9417267c335f21ec3d1505b26e56e5b3d5f4d3dbb555279489800aaa65a3bcd7bc376e274dd102912aec16ddbb18de2e2060b2667b41eb979cd9321e

45a5aaf Only call clear on prevector if it isn't trivially destructible and don't loop in clear (Jeremy Rubin) aaa02e7 Add prevector destructor benchmark (Jeremy Rubin) Tree-SHA512: 52bc8163b65b71310252f2d578349d0ddc364a6c23795c5e06e101f5449f04c96cbdca41c0cffb1974b984b8e33006471137d92b8dd4a81a98e922610a94132a

1269b8a Fix logging bug and improve readability of smartfees.py (Suhas Daftuar) b9f34e8 Improve readability of segwit.py (Suhas Daftuar) Tree-SHA512: 2c8ff61678c6c407a95a6530e9bd650ae6bb7c9e52f6dd5f256e19253a1358dd1a7aa33a9639fcb07f443e3a21dae71b9f0865c5f1fcaacb2097a3c6766c7eef

qa/rpc-tests/test_framework/mininode.py

src/wallet/wallet.cpp

contrib/gitian-descriptors/gitian-win.yml

doc/release-process.md

qa/rpc-tests/smartfees.py

src/wallet/wallet.h

qa/rpc-tests/test_framework/test_framework.py

UdjinM6

Looks good imo, test failures seems to be random/unrelated ones

utACK

codablock

LGTM (yeah, first time I use this correctly :D), except that the logging changes for tests should be applied to Dash specific tests as well. See here:
codablock@9b1b34a
codablock@7254f63

Should also remove freshly introduced references to RBF: codablock@c5d0cd6

codablock · 2019-03-08T08:27:18Z

contrib/windeploy/win-codesign.cert

@@ -0,0 +1,99 @@
+-----BEGIN CERTIFICATE-----


FYI, We'll need to add our own certificate here

codablock · 2019-03-08T08:29:44Z

contrib/verify-commits/trusted-sha512-root-commit

@@ -1 +1 @@
-f7ec7cfd38b543ba81ac7bed5b77f9a19739460b
+309bf16257b2395ce502017be627186b749ee749


FYI, need to specify a trusted commit into the Dash repo

codablock · 2019-03-08T08:53:12Z

Another thing: If swap_outputs_in_rawtx and DecimalEncoder in smartfees.py is not needed anymore, both should be dropped completely.

This reverts commit b06a6a2.

UdjinM6 · 2019-03-09T13:13:10Z

Looks good imo but we should either rebase this again and fix few more prints from #2735 or fix them later right after this PR is merged.

codablock · 2019-03-09T13:57:35Z

I'd vote for doing the print fixes after merge of this PR. Rebase at this stage would make life of reviewers harder.

UdjinM6

utACK

codablock

utACK. Test failures seem to be unrelated (working on a fix)

Related to dashpay/dash#2727

* RPC - Update masternode current and winner - Remove protocol, lastseen, activeseconds * RPC - Remove gobject getvotes - Related to dashpay/dash#2815 * RPC - Protx diff update - Add merkleRootQuorums field Related to dashpay/dash#2833 * RPC - listunspent update Related to dashpay/dash#2727 * RPC - protx update_registrar update - Rename votingKeyAddr to votingAddress Related to dashpay/dash#2747 * RPC - Add bls fromsecret Related to dashpay/dash#2841 * RPC - Start adding quorum RPCs * RPC - Add quorum info details Minor formatting updates * RPC - Add placeholders for remaining quorum sub-commands * RPC - Add quorum sign/hasrecsig/isconflicting details * RPC - Add note to regtest only quorum RPCs * RPC - Add more detail to quorum dkgstatus * Typo fix * Minor format and example updates * RPC - Add more quorum dkgstatus details - Field descriptions * RPC - Add quorum dkgstatus detail level 1 and 2 info * RPC - protx update - Remove support for "0" Related to dashpay/dash#2622

laanwj and others added 14 commits February 26, 2019 15:24

Merge bitcoin#9972: Fix extended rpc tests broken by bitcoin#9768

914bd78

d055bd6 Fix extended rpc tests broken by 8910b47 (John Newbery) Tree-SHA512: 30e019bd7e17013143e419777491ac0efd9760dddac7232d320c9afe80bc2fb383acd331e20cd5b3e21df1177c0e4a5221c99f831e90cf869d3affca206b9728

reset file perms

c3eb0c7

UdjinM6 requested changes Feb 27, 2019

View reviewed changes

PastaPastaPasta force-pushed the backports-0.15-pr7 branch 2 times, most recently from 492b149 to fb435ae Compare March 3, 2019 19:32

UdjinM6 reviewed Mar 3, 2019

View reviewed changes

qa/rpc-tests/test_framework/test_framework.py Outdated Show resolved Hide resolved

code review and reset file perms

0db2d15

PastaPastaPasta force-pushed the backports-0.15-pr7 branch from fb435ae to 0db2d15 Compare March 4, 2019 02:50

UdjinM6 previously approved these changes Mar 4, 2019

View reviewed changes

UdjinM6 added this to the 14.0 milestone Mar 4, 2019

UdjinM6 added the RPC Some notable changes to RPC params/behaviour/descriptions label Mar 5, 2019

UdjinM6 requested a review from codablock March 6, 2019 19:46

codablock reviewed Mar 8, 2019

View reviewed changes

codablock added 2 commits March 8, 2019 14:22

Use logging framework in Dash specific tests

0e91ebc

Revert "Fix use of missing self.log in blockchain.py"

bc593c8

This reverts commit b06a6a2.

PastaPastaPasta dismissed UdjinM6’s stale review via bc593c8 March 8, 2019 20:23

drop swap_outputs_in_rawtx and DecimalEncoder in smartfees.py

85ffc1d

Code review: re-add string cast in mininode.py

609114a

UdjinM6 approved these changes Mar 9, 2019

View reviewed changes

codablock approved these changes Mar 11, 2019

View reviewed changes

UdjinM6 merged commit 9f40afc into dashpay:develop Mar 11, 2019

PastaPastaPasta deleted the backports-0.15-pr7 branch March 11, 2019 11:21

thephez added a commit to thephez/dash-docs that referenced this pull request Apr 8, 2019

RPC - listunspent update

eff2fb5

Related to dashpay/dash#2727

thephez added a commit to thephez/dash-docs that referenced this pull request Apr 8, 2019

RPC - listunspent update

0581c5b

Related to dashpay/dash#2727

		@@ -1 +1 @@
		f7ec7cfd38b543ba81ac7bed5b77f9a19739460b
		309bf16257b2395ce502017be627186b749ee749

Backports 0.15 pr7 #2727

Backports 0.15 pr7 #2727

Uh oh!

Conversation

PastaPastaPasta commented Feb 26, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

codablock left a comment

Choose a reason for hiding this comment

Uh oh!

codablock Mar 8, 2019

Choose a reason for hiding this comment

Uh oh!

codablock Mar 8, 2019

Choose a reason for hiding this comment

Uh oh!

codablock commented Mar 8, 2019

Uh oh!

UdjinM6 commented Mar 9, 2019

Uh oh!

codablock commented Mar 9, 2019

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

codablock left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants