Backport #14701: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString #2687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…foString 8e20934 build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (fanquake) Pull request description: As mentioned in bitcoin#14697, if you download the `0.17.0.1` dmg, and inspect the `.app` bundle, the version in the GetInfo string reads `0.17.0`, which is confusing given you're expecting `0.17.0.1`: <img width="391" alt="0 17 0 1" src="https://user-images.githubusercontent.com/863730/48300032-fbb54b00-e510-11e8-9bcd-77e1fffffc63.png"> This PR adds `CLIENT_VERSION_BUILD` to the string, so that the full version number is displayed, i.e: <img width="327" alt="this pr" src="https://user-images.githubusercontent.com/863730/48300015-7893f500-e510-11e8-98b9-80424719a082.png"> Tree-SHA512: f553253d03283639cc4dda00c8004b5c63ae2b489762e5e8c666166e71b14e672792c1df678f87484d51d153b5781c5ec1b145774096600f504833024ae8baea
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Mar 7, 2019
…tInfoString (dashpay#2687) 8e20934 build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (fanquake) Pull request description: As mentioned in bitcoin#14697, if you download the `0.17.0.1` dmg, and inspect the `.app` bundle, the version in the GetInfo string reads `0.17.0`, which is confusing given you're expecting `0.17.0.1`: <img width="391" alt="0 17 0 1" src="https://user-images.githubusercontent.com/863730/48300032-fbb54b00-e510-11e8-9bcd-77e1fffffc63.png"> This PR adds `CLIENT_VERSION_BUILD` to the string, so that the full version number is displayed, i.e: <img width="327" alt="this pr" src="https://user-images.githubusercontent.com/863730/48300015-7893f500-e510-11e8-98b9-80424719a082.png"> Tree-SHA512: f553253d03283639cc4dda00c8004b5c63ae2b489762e5e8c666166e71b14e672792c1df678f87484d51d153b5781c5ec1b145774096600f504833024ae8baea
MIPPL
pushed a commit
to biblepay/biblepay
that referenced
this pull request
May 26, 2019
* commit '4570079e53ad859c571aeac3f132cf2969888e14': Add missing entry to changelog (dashpay#2769) Move IS block filtering into ConnectBlock (dashpay#2766) [0.13.x] Bump version to 0.13.2 and add release notes (dashpay#2749) Bump minChainWork and AssumeValid to block #1033120 (dashpay#2750) Fix error message for invalid voting addresses (dashpay#2747) Make -masternodeblsprivkey mandatory when -masternode is given (dashpay#2745) Implement 2-stage commit for CEvoDB to avoid inconsistencies after crashes (dashpay#2744) Add collateraladdress into masternode/protx list rpc output (dashpay#2740) Only include selected TX types into CMerkleBlock (dashpay#2737) Stop g_connman first before deleting it (dashpay#2734) Fix incorrect usage of begin() when genesis block is requested in "protx diff" (dashpay#2699) Do not process blocks in CDeterministicMNManager before dip3 activation (dashpay#2698) Backport bitcoin#14701: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (dashpay#2687) Fix some typos in doc/guide-startmany.md (dashpay#2711) Minimal fix for litemode vs bad-protx-key-not-same issue (dashpay#2694) Release notes v0.13.1.0 (dashpay#2689) # Conflicts: # configure.ac # doc/guide-startmany.md # doc/release-notes.md # src/chainparams.cpp # src/clientversion.h # src/validation.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8e20934 build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (fanquake)
Pull request description:
As mentioned in bitcoin#14697, if you download the
0.17.0.1dmg, and inspect the.appbundle, the version in the GetInfo string reads0.17.0, which is confusing given you're expecting0.17.0.1:This PR adds
CLIENT_VERSION_BUILDto the string, so that the full version number is displayed, i.e:Tree-SHA512: f553253d03283639cc4dda00c8004b5c63ae2b489762e5e8c666166e71b14e672792c1df678f87484d51d153b5781c5ec1b145774096600f504833024ae8baea
fixes #2423