Optimize DKG debug message processing for performance and lower bandwidth #2672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssionStatus No need to waste one byte per member and per LLMQ type.
Profiling has shown that a lot of time is spent in resizing the data vector when large messages are involved.
This field changes every block and causes all masternodes to propagate its status for every block, even if nothing DKG related has changed.
Otherwise MNs which are not members of DKG sessions will spam the network
This is not bound to a session and thus is prone to spam the network when final commitments are propagated in the finalization phase.
"statuses" only contains the current messages but none of the old messages, so nodes kept re-requesting old messages.
| if (ban) { | ||
| LOCK(cs_main); | ||
| Misbehaving(pfrom->id, 10); | ||
| return; |
Member
There was a problem hiding this comment.
I'd prefer a comment here on what action etc it is punishing
UdjinM6
added
P2P
Fuzzbawls
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Aug 9, 2024
22efef0 No matter how fast we process sig shares, always force 100ms between sending (Alexander Block) 1bd0c2f Don't sleep in WorkThreadMain when CPU intensive work was done (Alexander Block) 40a247d Implement caching in CRecoveredSigsDb (Alexander Block) 6c63a77 Use CBLSLazySignature in CBatchedSigShares (Alexander Block) bff6e6e CLLMQUtils::IsQuorumActive() shouldn't require cs_main to be held (UdjinM6) fdba615 Introduce startBlockHeight to make things more explicit (Alexander Block) 7bca9a2 Correctly use SIGN_HEIGHT_OFFSET when checking for out of bound height (Alexander Block) 04b6a67 Reserve 4k of buffer for CSerializedNetMsg buffer (Alexander Block) be1c4a7 Fix cleanup of old recovered sigs (Alexander Block) Pull request description: Backport dash PRs (in the following order): dashpay#2640 dashpay#2672 dashpay#2674 dashpay#2702 dashpay#2705 dashpay#2706 dashpay#2707 NB: Some or them are partial backports since most of our llmq files are already updated to a more recent upstream version. So I basically ended up picking the commits that touch only the files `quorums_signing_shares.*` and `quorums_signing.*` I suggest to review by checking each individual commit against the corresponding upstream one ACKs for top commit: 22efef0 Liquid369: tACK 22efef0 Duddino: ACK 22efef0 Tree-SHA512: 94e5dcdef044524ad4fa4d1fadbe670d839a08ccadc39071ba9300cfc44ce3d19ba24dfef1a6c6745271139d43f43ea47ed5a29e06f0d94e13ff09957f8e0c10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling has shown that a lot of time is spent processing DKG debug messages. There are multiple reasons for this:
See individual commits for the fixes