De-dashify env vars and dashify help text in tests instead #2603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
codablock
approved these changes
Jan 3, 2019
codablock
left a comment
codablock
left a comment
There was a problem hiding this comment.
utACK, but can you explain why it was "horribly wrong"? Did you find some issues with this?
Author
|
Well, I mean, "search&replace" for some variable in just one part of the code without fixing it everywhere is already wrong. Doing so for env var should be a no-go but I did this for some reason and no one noticed, which is horrible :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like some very old dashification went horribly wrong and this stayed unnoticed for ~3 years 🙈
Note:
qa/pull-tester/rpc-tests.pyis going to be "fixed" by #2590 , not touching it here to avoid merge conflicts.