Fix spork propagation while in IBD and fix spork integration tests #2533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpay#2522 caused an issue with sporks syncing in tests. The introduced time check in CMasternodeSync::ProcessTick causes masternode sync to never start when mocktime is enabled, so this commit disables mocktime for sporks.py. Disabling mocktime however leads to fInitialDownload never becoming false in CMasternodeSync::UpdatedBlockTip, so mnsync is never started. To fix this, the tests now create a block before connecting the last node. This however doesn't work because node1 will ignore the "getheaders" request from node2 as it has not finished mnsync yet...so we also have to force finish mnsync for node1.
There was never a good reason to ignore spork announcements while in IBD. At the same time, this poses the risk of missing out on sporks while in IBD. This also fixes an issue in sporks testing, as nodes did not request for announced sporks.
UdjinM6
reviewed
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.