Properly initialize confirmedHash in CSimplifiedMNListEntry #2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hard-fork is required on testnet as we have to fix a few consensus bugs in DIP3/DIP4. It will also be required to introduce LLMQ commitments to testnet.
...before fork activation. Otherwise we'd invalidate all DIP3 blocks on testnet.
Author
|
I bumped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that the confirmedHash field in the DIP4 p2p messages is always empty. The reason was simply that it was not initialized in the CSimplifiedMNListEntry.
Fixing this would however invalidate all DIP3 blocks, so we'll have to add some temporary fork logic. This fork logic can be removed when we later reset testnet. The fork-height is currently set to 271000, which we might need to increase if the next RC takes too long.