Add IS parameter for gobject prepare #2452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: PastaPastaPasta <[email protected]>
UdjinM6
requested changes
Nov 16, 2018
Co-Authored-By: PastaPastaPasta <[email protected]>
Co-Authored-By: PastaPastaPasta <[email protected]>
|
I'm wondering why these need to be sent via instant send? Would the governance code even accept the collaterals before they are confirmed on-chain? |
Member
Author
|
The rest of the code is setup to accept it after one on chain conf + IS, as opposed to 6 normally |
thephez
added a commit
to dash-docs/dash-docs
that referenced
this pull request
Dec 13, 2018
Use-IS (dashpay/dash#2452) Use specific UTXO for fee (dashpay/dash#2482)
thephez
added a commit
to dash-docs/dash-docs
that referenced
this pull request
Dec 26, 2018
* Content - RPC - Update quick reference * RPC - Update getblockchaininfo to show BIP-9 progress Related to dashpay/dash#2435 * RPC - Update gobject prepare with new params Use-IS (dashpay/dash#2452) Use specific UTXO for fee (dashpay/dash#2482) * RPC - Update mode name * RPC - Update protx default mode dashpay/dash#2513 * Content - Add spork 17 * Content - Special transactions Add info for Quorum commitment Remove messages not in 13.0 (SubTx) * P2P - Add new txlvote fields masternodeProTxHash (dashpay/dash#2484) quorumModifierHash (dashpay/dash#2505) * RPC - Update protx list Make all options follow the same parameter format (dashpay/dash#2559) * Content - version bump 0.13.0.0 bumped to 70213 (dashpay/dash#2557) * Guide - PrivateSend dstx message limit Up to 5 simultaneous dstxs per MN allowed (dashpay/dash#2552) * RPC - Update getblock Add missing versionHex field (dashpay/dash@e7d9ffa) Change to use verbosity syntax (dashpay/dash#2506 and bitcoin/bitcoin#8704) * P2P - Add qfcommit message (no hexdump example) DIP6 quorum final commitment (dashpay/dash#2477) * P2P - qfcommit typo Change description of llmqType field * P2P - Special tx payload size clarification * Guide - Update MN payment description Related to dashpay/dash#2258 * Guide - fix broken link * Guide - Update some example txs Change to hashes on the chain following the 12.3.4 reset * P2P - Add QcTx hexdump * P2P - DIP4 message updates Add SML entry Update hexdump to include new fields Add getmnlistd and mnlistdiff to cross ref * P2P - minor DIP3-related comments
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Jun 29, 2020
* Add IS parameter for gobject prepare * Update if statement Co-Authored-By: PastaPastaPasta <[email protected]> * Update src/rpc/governance.cpp Co-Authored-By: PastaPastaPasta <[email protected]> * Update src/rpc/governance.cpp Co-Authored-By: PastaPastaPasta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of the gobject code has been IS compatible since the start, however the parameter was never added to actually allow users to use it. Hence forth, users will run
gobject prepareand addtrueas a 5th parameter if they want it to be locked via IS. In such a case,gobject submitcan be submitted as soon as a new block is mined. If they don't use the IS lock feature they will have to wait 6 blocks in order to run thegobject submitcommand.