Backport bitcoin #13623 Migrate gitian-build.sh to python #2319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename gitian-build script fix release notes typo 0.12.3-backports
Author
|
testing docker/etc fixes |
codablock
reviewed
Oct 19, 2018
codablock
left a comment
codablock
left a comment
There was a problem hiding this comment.
utACK for the script itself. Added a few comments which are mostly for a new PR as I assume.
I'm testing this atm and will report back later
|
@charlesrocket btw, while looking into the commits I noticed that you're using a strange user-name ( |
Author
|
@codablock yes, but thats not a strange one yet 😄 - I think you can use unicode as well, but never really tried |
UdjinM6
requested changes
Oct 20, 2018
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Looks good but I would like to see #2319 (comment) addressed.
checksum added
Author
|
@UdjinM6 added SDK with checksum |
UdjinM6
reviewed
Oct 20, 2018
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
May 4, 2021
…hpay#2319) * backport python version of gitian-build from bitcoin rename gitian-build script fix release notes typo 0.12.3-backports * change gitian host IP address * docker/etc fixes * use docker as default virtualization tech * add checksum to depends download stage * add SDK download checksum added * remove SDK check * fix verification
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
May 4, 2021
Backport bitcoin bitcoin#13623 Migrate gitian-build.sh to python (dashpay#2319) * backport python version of gitian-build from bitcoin
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build system is still unstable on Debian due poor bionic support on
stabledebootstrap