Honor filterInventoryKnown for non-tx/non-block items #2292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
commented
Sep 14, 2018
| } | ||
|
|
||
|
|
||
| void AddInventoryKnown(const CInv& inv) |
Author
There was a problem hiding this comment.
FYI, this one is not used in this PR, but will later be used in the LLMQ code
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not honoring/updating filterInventoryKnown for non-tx/non-block items, which in some cases resulted in items being sent multiple times. Observes this very often when testing LLMQs, which require some quite large messages to be propagated.