Extend Bloom Filter support to InstantSend related messages #2184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
reviewed
Jul 16, 2018
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
In general looks good but I have a few coding style remarks, see inline comments.
src/net.cpp
Outdated
| } | ||
|
|
||
| void CConnman::RelayInvFiltered(CInv &inv, | ||
| const CTransaction& relatedTx, |
There was a problem hiding this comment.
code style: no need for multiple lines here imo
src/net.cpp
Outdated
|
|
||
| void CConnman::RelayInvFiltered(CInv &inv, | ||
| const CTransaction& relatedTx, | ||
| const int minProtoVersion) { |
There was a problem hiding this comment.
code style: { should be on new lines for functions
src/net.cpp
Outdated
| { | ||
| LOCK(pnode->cs_filter); // TODO: do we need it? | ||
| if(pnode->pfilter && | ||
| !pnode->pfilter->IsRelevantAndUpdate(relatedTx)) |
There was a problem hiding this comment.
code style: no need for multiple lines here imo
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Apr 25, 2019
…2184) * use bloom filters for IX lock votes * code style fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for issue #1677, add filtering during relay for lock votes