Skip to content

Conversation

@eduffield222
Copy link

Reverts #187

eduffield222 pushed a commit that referenced this pull request Feb 19, 2015
@eduffield222 eduffield222 merged commit 93efb82 into v0.11.2.x Feb 19, 2015
@eduffield222 eduffield222 deleted the revert-187-devel-0.9-strings branch March 7, 2015 15:57
knst pushed a commit to knst/dash that referenced this pull request Sep 26, 2024
ecbd911 qt: Handle peer addition/removal in a right way (Hennadii Stepanov)
1b66f6e qt: Drop PeerTablePriv class (Hennadii Stepanov)
efb7e5a qt, refactor: Use default arguments for overridden functions (Hennadii Stepanov)

Pull request description:

  This PR makes `PeerTableModel` handle a peer addition/removal in a right way. See:
  - https://doc.qt.io/qt-5/model-view-programming.html#inserting-and-removing-rows
  - https://doc.qt.io/qt-5/model-view-programming.html#resizable-models

  Fixes dashpay#160.

  Fixes dashpay#191.

ACKs for top commit:
  jarolrod:
    re-ACK ecbd911
  promag:
    reACK ecbd911 just improvements to the comment since last review.

Tree-SHA512: 074935d67f78561724218e8b33822e2de16749f873c29054926b720ffcd642f08249a222b563983cf65a9b716290aa14e2372c47fc04e5f401f759db25ca710f
knst pushed a commit to knst/dash that referenced this pull request Sep 26, 2024
ecbd911 qt: Handle peer addition/removal in a right way (Hennadii Stepanov)
1b66f6e qt: Drop PeerTablePriv class (Hennadii Stepanov)
efb7e5a qt, refactor: Use default arguments for overridden functions (Hennadii Stepanov)

Pull request description:

  This PR makes `PeerTableModel` handle a peer addition/removal in a right way. See:
  - https://doc.qt.io/qt-5/model-view-programming.html#inserting-and-removing-rows
  - https://doc.qt.io/qt-5/model-view-programming.html#resizable-models

  Fixes dashpay#160.

  Fixes dashpay#191.

ACKs for top commit:
  jarolrod:
    re-ACK ecbd911
  promag:
    reACK ecbd911 just improvements to the comment since last review.

Tree-SHA512: 074935d67f78561724218e8b33822e2de16749f873c29054926b720ffcd642f08249a222b563983cf65a9b716290aa14e2372c47fc04e5f401f759db25ca710f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants