Skip to content

Conversation

@vertoe
Copy link

@vertoe vertoe commented Feb 14, 2015

sipa and others added 6 commits February 5, 2015 20:56
3230b32 Raise version of created blocks, and enforce DERSIG in mempool (Pieter Wuille)
989d499 Backport of some of BIP66's tests (Pieter Wuille)
ab03660 Implement BIP 66 validation rules and switchover logic (Pieter Wuille)
Normally bitcoin core does not display any network originated strings without
 sanitizing or hex encoding.  This wasn't done for strcommand in many places.

This could be used to play havoc with a terminal displaying the logs,
 especially with printtoconsole in use.

Thanks to Evil-Knievel for reporting this issue.

Conflicts:
	src/main.cpp
	src/net.cpp
	src/rpcserver.cpp

Rebased-From: 28d4cff
Github-Pull: dashpay#5770
@vertoe
Copy link
Author

vertoe commented Feb 14, 2015

And bitcoin#5770

eduffield222 pushed a commit that referenced this pull request Feb 14, 2015
@eduffield222 eduffield222 merged commit 3d004ab into dashpay:v0.11.2.x Feb 14, 2015
@vertoe
Copy link
Author

vertoe commented Feb 16, 2015

We have to include this into the 0.11.2 release notes:

Mining and relay policy enhancements

Darkcoin Core's block templates are now for version 3 blocks only, and any mining software relying on its getblocktemplate must be updated in parallel to use libblkmaker either version 0.4.2 or any version from 0.5.1 onward. If you are solo mining, this will affect you the moment you upgrade Darkcoin Core, which must be done prior to BIP66 achieving its 951/1001 status. If you are mining with the stratum mining protocol: this does not affect you. If you are mining with the getblocktemplate protocol to a pool: this will affect you at the pool operator's discretion, which must be no later than BIP66 achieving its 951/1001 status.

BIP 66: strict DER encoding for signatures

Darkcoin Core 0.11.2 implements BIP 66, which introduces block version 3, and a new consensus rule, which prohibits non-DER signatures. Such transactions have been non-standard since Darkcoin 0.8, but were technically still permitted inside blocks.
This change breaks the dependency on OpenSSL's signature parsing, and is required if implementations would want to remove all of OpenSSL from the consensus code.
The same miner-voting mechanism as in BIP 34 is used: when 751 out of a sequence of 1001 blocks have version number 3 or higher, the new consensus rule becomes active for those blocks. When 951 out of a sequence of 1001 blocks have version number 3 or higher, it becomes mandatory for all blocks.
Backward compatibility with current mining software is NOT provided, thus miners should read the first paragraph of "Mining and relay policy enhancements" above.

Also compare with upstream release notes: https://github.com/bitcoin/bitcoin/blob/0.10/doc/release-notes.md#mining-and-relay-policy-enhancements
More info on BIP 66: https://github.com/bitcoin/bips/blob/master/bip-0066.mediawiki

@vertoe vertoe deleted the devel-0.9-upstream branch March 1, 2015 23:04
FornaxA pushed a commit to ioncoincore/ion that referenced this pull request Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants