Backport Bitcoin PRs #6589, #7180 and remaining part of #7181: enable per-command byte counters in CNode
#1496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like these were forgotten in dashpay#6589.
Most of this PR is already merged, but a small part remaining that makes per-command byte counts in CNode working. Signed-off-by: Oleg Girko <[email protected]>
tgflynn
approved these changes
Jun 29, 2017
tgflynn
left a comment
tgflynn
left a comment
There was a problem hiding this comment.
👍
Aside from making subsequent commits easier to merge this PR looks very useful on its own. Could definitely help with debugging/better understanding network issues.
utACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes that enable per-command byte counters in
CNodethat can be accessed usinggetpeerinfoRPC call.This is backport of 3 Bitcoin PRs:
sendheadersverackmessages bitcoin/bitcoin#7180,Note that third commit partially cancel first one, so I'd recommend reviewing total change, not per-commit ones.
This is the first in series of PRs for big networking refactoring. Although it's not strictly necessary, it makes further refactoring easier because some subsequent changes touch parts of code affected by these changes.