refactor: spin-off list of option IDs that require string workaround

kwvg · kwvg · commit eed631a72a0a · 2026-01-03T23:25:14.000+05:30
We have a lot more configurable options and the current approach will
get unwieldy as it grows
diff --git a/src/qt/optionsmodel.cpp b/src/qt/optionsmodel.cpp
@@ -64,14 +64,23 @@ static const char* SettingName(OptionsModel::OptionID option)
     }
 }
 
+static bool RequiresNumWorkaround(OptionsModel::OptionID option)
+{
+    switch (option) {
+    case OptionsModel::DatabaseCache:
+    case OptionsModel::Prune:
+    case OptionsModel::PruneSize:
+    case OptionsModel::ThreadsScriptVerif:
+        return true;
+    default:
+        return false;
+    }
+}
+
 /** Call node.updateRwSetting() with Bitcoin 22.x workaround. */
 static void UpdateRwSetting(interfaces::Node& node, OptionsModel::OptionID option, const util::SettingsValue& value)
 {
-    if (value.isNum() &&
-        (option == OptionsModel::DatabaseCache ||
-         option == OptionsModel::ThreadsScriptVerif ||
-         option == OptionsModel::Prune ||
-         option == OptionsModel::PruneSize)) {
+    if (value.isNum() && RequiresNumWorkaround(option)) {
         // Write certain old settings as strings, even though they are numbers,
         // because Bitcoin 22.x releases try to read these specific settings as
         // strings in addOverriddenOption() calls at startup, triggering
