refactor: add util::to_string(bool) for convenience

kwvg · kwvg · commit e92a7646dd83 · 2026-01-10T22:52:06.000+05:30
diff --git a/src/coinjoin/coinjoin.cpp b/src/coinjoin/coinjoin.cpp
@@ -8,6 +8,7 @@
 #include <chainlock/chainlock.h>
 #include <instantsend/instantsend.h>
 #include <masternode/sync.h>
+#include <util/helpers.h>
 
 #include <chain.h>
 #include <chainparams.h>
@@ -64,7 +65,7 @@ bool CCoinJoinQueue::IsTimeOutOfBounds(int64_t current_time) const
 [[nodiscard]] std::string CCoinJoinQueue::ToString() const
 {
     return strprintf("nDenom=%d, nTime=%lld, fReady=%s, fTried=%s, masternode=%s",
-        nDenom, nTime, fReady ? "true" : "false", fTried ? "true" : "false", masternodeOutpoint.ToStringShort());
+        nDenom, nTime, util::to_string(fReady), util::to_string(fTried), masternodeOutpoint.ToStringShort());
 }
 
 uint256 CCoinJoinBroadcastTx::GetSignatureHash() const
diff --git a/src/llmq/quorumsman.cpp b/src/llmq/quorumsman.cpp
@@ -285,7 +285,7 @@ std::vector<CQuorumCPtr> CQuorumManager::ScanQuorums(Consensus::LLMQType llmqTyp
         if (!quorum) {
             LogPrintf("%s: ERROR! Unexpected missing quorum with llmqType=%d, blockHash=%s, populate_cache=%s\n",
                       __func__, std23::to_underlying(llmqType), pQuorumBaseBlockIndex->GetBlockHash().ToString(),
-                      populate_cache ? "true" : "false");
+                      util::to_string(populate_cache));
             return {};
         }
         vecResultQuorums.emplace_back(quorum);
diff --git a/src/qt/guiutil_font.cpp b/src/qt/guiutil_font.cpp
@@ -4,6 +4,8 @@
 
 #include <qt/guiutil_font.h>
 
+#include <util/helpers.h>
+
 #include <tinyformat.h>
 #include <util/system.h>
 
@@ -352,7 +354,7 @@ void setApplicationFont()
 
     qDebug() << qstrprintf("%s: %s family: %s, style: %s match: %s", __func__, qApp->font().toString().toStdString(),
                            qApp->font().family().toStdString(), qApp->font().styleName().toStdString(),
-                           qApp->font().exactMatch() ? "true" : "false");
+                           util::to_string(qApp->font().exactMatch()));
 }
 
 void setFont(const std::vector<QWidget*>& vecWidgets, const FontAttrib& font_attrib)
@@ -518,7 +520,7 @@ QFont getFont(const FontAttrib& font_attrib)
     if (gArgs.GetBoolArg("-debug-ui", false)) {
         qDebug() << qstrprintf("%s: font size: %d, family: %s, style: %s, weight: %d match %s", __func__,
                                font.pointSizeF(), font.family().toStdString(), font.styleName().toStdString(),
-                               font.weight(), font.exactMatch() ? "true" : "false");
+                               font.weight(), util::to_string(font.exactMatch()));
     }
 
     return font;
diff --git a/src/rpc/mempool.cpp b/src/rpc/mempool.cpp
@@ -5,6 +5,10 @@
 
 #include <rpc/blockchain.h>
 
+#include <instantsend/instantsend.h>
+#include <llmq/context.h>
+#include <util/helpers.h>
+
 #include <core_io.h>
 #include <fs.h>
 #include <policy/settings.h>
@@ -19,9 +23,6 @@
 #include <util/system.h>
 #include <util/time.h>
 
-#include <instantsend/instantsend.h>
-#include <llmq/context.h>
-
 using node::DEFAULT_MAX_RAW_TX_FEE_RATE;
 using node::NodeContext;
 
@@ -325,7 +326,7 @@ static void entryToJSON(const CTxMemPool& pool, UniValue& info, const CTxMemPool
     }
 
     info.pushKV("spentby", spent);
-    info.pushKV("instantlock", isman ? (isman->IsLocked(tx.GetHash()) ? "true" : "false") : "unknown");
+    info.pushKV("instantlock", isman ? util::to_string(isman->IsLocked(tx.GetHash())) : "unknown");
     info.pushKV("unbroadcast", pool.IsUnbroadcastTx(tx.GetHash()));
 }
 
diff --git a/src/util/helpers.h b/src/util/helpers.h
@@ -8,6 +8,7 @@
 #include <memory>
 #include <optional>
 #include <ranges>
+#include <string_view>
 
 namespace util {
 template <typename X, typename Z>
@@ -43,6 +44,11 @@ inline bool shared_ptr_not_equal(const std::shared_ptr<T>& lhs, const std::share
     if (!lhs || !rhs) return true;  // Inequal initialization state
     return *lhs != *rhs;            // Deep comparison
 }
+
+inline constexpr std::string_view to_string(bool value)
+{
+    return value ? "true" : "false";
+}
 } // namespace util
 
 #endif // BITCOIN_UTIL_HELPERS_H

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`	`#include <chainlock/chainlock.h>`
`9`	`9`	`#include <instantsend/instantsend.h>`
`10`	`10`	`#include <masternode/sync.h>`
	`11`	`+#include <util/helpers.h>`
`11`	`12`
`12`	`13`	`#include <chain.h>`
`13`	`14`	`#include <chainparams.h>`
`@@ -64,7 +65,7 @@ bool CCoinJoinQueue::IsTimeOutOfBounds(int64_t current_time) const`
`64`	`65`	`[[nodiscard]] std::string CCoinJoinQueue::ToString() const`
`65`	`66`	`{`
`66`	`67`	`return strprintf("nDenom=%d, nTime=%lld, fReady=%s, fTried=%s, masternode=%s",`
`67`		`- nDenom, nTime, fReady ? "true" : "false", fTried ? "true" : "false", masternodeOutpoint.ToStringShort());`
	`68`	`+ nDenom, nTime, util::to_string(fReady), util::to_string(fTried), masternodeOutpoint.ToStringShort());`
`68`	`69`	`}`
`69`	`70`
`70`	`71`	`uint256 CCoinJoinBroadcastTx::GetSignatureHash() const`
Original file line number	Diff line number	Diff line change
`@@ -285,7 +285,7 @@ std::vector<CQuorumCPtr> CQuorumManager::ScanQuorums(Consensus::LLMQType llmqTyp`
`285`	`285`	`if (!quorum) {`
`286`	`286`	`LogPrintf("%s: ERROR! Unexpected missing quorum with llmqType=%d, blockHash=%s, populate_cache=%s\n",`
`287`	`287`	`__func__, std23::to_underlying(llmqType), pQuorumBaseBlockIndex->GetBlockHash().ToString(),`
`288`		`- populate_cache ? "true" : "false");`
	`288`	`+ util::to_string(populate_cache));`
`289`	`289`	`return {};`
`290`	`290`	`}`
`291`	`291`	`vecResultQuorums.emplace_back(quorum);`