merge bitcoin#24002: add thread safety lock assertion to WriteBlockIndexDB()

kwvg · kwvg · commit e5e37458bb69 · 2024-07-23T17:45:24.000Z
diff --git a/src/node/blockstorage.cpp b/src/node/blockstorage.cpp
@@ -331,6 +331,7 @@ void BlockManager::Unload()
 
 bool BlockManager::WriteBlockIndexDB()
 {
+    AssertLockHeld(::cs_main);
     std::vector<std::pair<int, const CBlockFileInfo*>> vFiles;
     vFiles.reserve(m_dirty_fileinfo.size());
     for (std::set<int>::iterator it = m_dirty_fileinfo.begin(); it != m_dirty_fileinfo.end();) {

Original file line number	Diff line number	Diff line change
`@@ -331,6 +331,7 @@ void BlockManager::Unload()`
`331`	`331`
`332`	`332`	`bool BlockManager::WriteBlockIndexDB()`
`333`	`333`	`{`
	`334`	`+ AssertLockHeld(::cs_main);`
`334`	`335`	`std::vector<std::pair<int, const CBlockFileInfo*>> vFiles;`
`335`	`336`	`vFiles.reserve(m_dirty_fileinfo.size());`
`336`	`337`	`for (std::set<int>::iterator it = m_dirty_fileinfo.begin(); it != m_dirty_fileinfo.end();) {`