Apply suggestions from code review

xdustinface · UdjinM6 · web-flow · commit dfebc25f37d6 · 2020-08-15T00:34:01.000+02:00
Co-authored-by: UdjinM6 &lt;UdjinM6@users.noreply.github.com&gt;
diff --git a/src/privatesend/privatesend-client.cpp b/src/privatesend/privatesend-client.cpp
@@ -1653,7 +1653,7 @@ bool CPrivateSendClientSession::CreateDenominated(CAmount nBalanceToDenominate,
             while(true) {
                 // Create an potential output
                 vecOutputs.push_back(nAmount);
-                if (!txBuilder.TryAddOutputs(vecOutputs) || txBuilder.CountOutputs() + vecOutputs.size() >= PRIVATESEND_DENOM_OUTPUTS_THRESHOLD) {
+                if (!txBuilder.TryAddOutputs(vecOutputs) || txBuilder.CountOutputs() + vecOutputs.size() > PRIVATESEND_DENOM_OUTPUTS_THRESHOLD) {
                     // If its not possible to add it due to insufficient amount left or total number of outputs exceeds
                     // PRIVATESEND_DENOM_OUTPUTS_THRESHOLD drop the output again and stop trying.
                     vecOutputs.pop_back();
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -3975,7 +3975,7 @@ bool CWallet::CreateTransaction(const std::vector<CRecipient>& vecSend, CWalletT
                     // change output. Only try this once.
                     if (nChangePosInOut == -1 && nSubtractFeeFromAmount == 0 && pick_new_inputs) {
                         // Adding another output can change the serialized size of the vout size
-                        unsigned int tx_size_with_change = nBytes + change_prototype_size + GetSizeOfCompactSizeDiff(0, txNew.vout.size() + 1);
+                        unsigned int tx_size_with_change = nBytes + change_prototype_size + GetSizeOfCompactSizeDiff(txNew.vout.size(), txNew.vout.size() + 1);
                         CAmount fee_needed_with_change = GetMinimumFee(tx_size_with_change, coin_control, ::mempool, ::feeEstimator, nullptr);
                         CAmount minimum_value_for_change = GetDustThreshold(change_prototype_txout, discard_rate);
                         if (nFeeRet >= fee_needed_with_change + minimum_value_for_change) {
