ci: stop running check-symbols during builds

kwvg · kwvg · commit decbd05b77aa · 2024-11-02T21:34:10.000Z
Guix runs `check-symbols` during its builds and retains value there as
those builds are expected to run on platforms/distros that have that
pinned version of glibc or higher (pinned in `manifest.scm` as 2.28 and
checked to make sure ABIs present in versions higher than 2.31 aren't
used by `symbol-check.py`).

There's no reason to do this on regular builds, which aren't expected
to be as portable, built in an environment that's much less customizable.
diff --git a/ci/dash/build_src.sh b/ci/dash/build_src.sh
@@ -63,7 +63,3 @@ fi
 if [ "$RUN_SECURITY_TESTS" = "true" ]; then
   make test-security-check
 fi
-
-if [ "$RUN_SYMBOL_TESTS" = "true" ]; then
-  make $MAKEJOBS -C src check-symbols
-fi
diff --git a/ci/test/00_setup_env.sh b/ci/test/00_setup_env.sh
@@ -46,7 +46,6 @@ export RUN_SECURITY_TESTS=${RUN_SECURITY_TESTS:-false}
 export TEST_RUNNER_TIMEOUT_FACTOR=${TEST_RUNNER_TIMEOUT_FACTOR:-4}
 export TEST_RUNNER_ENV=${TEST_RUNNER_ENV:-}
 export RUN_FUZZ_TESTS=${RUN_FUZZ_TESTS:-false}
-export RUN_SYMBOL_TESTS=${RUN_SYMBOL_TESTS:-false}
 export EXPECTED_TESTS_DURATION_IN_SECONDS=${EXPECTED_TESTS_DURATION_IN_SECONDS:-1000}
 
 export CONTAINER_NAME=${CONTAINER_NAME:-ci_unnamed}
diff --git a/ci/test/00_setup_env_native_qt5.sh b/ci/test/00_setup_env_native_qt5.sh
@@ -16,4 +16,3 @@ export RUN_UNIT_TESTS="false"
 export GOAL="install"
 export PREVIOUS_RELEASES_TO_DOWNLOAD="v0.15.0.0 v0.16.1.1 v0.17.0.3 v18.2.2 v19.3.0 v20.0.1"
 export BITCOIN_CONFIG="--enable-zmq --with-libs=no --enable-reduce-exports --disable-fuzz-binary LDFLAGS=-static-libstdc++ --with-boost-process"
-export RUN_SYMBOL_TESTS="true"
