fix: skip functional tests which requires BDB if no bdb (see 20267)

knst · knst · commit da8e5639ee81 · 2024-03-07T01:23:23.000+07:00
Skipped tests:
 - feature_filelock
 - wallet_descriptors
 - interface_bitcoin_cli
And all functional tests which explitely specify they are using non-descriptor wallets
diff --git a/test/functional/feature_filelock.py b/test/functional/feature_filelock.py
@@ -15,6 +15,10 @@ def set_test_params(self):
         self.setup_clean_chain = True
         self.num_nodes = 2
 
+    # TODO: remove it after 20267 done
+    def skip_test_if_missing_module(self):
+        self.skip_if_no_bdb()
+
     def setup_network(self):
         self.add_nodes(self.num_nodes, extra_args=None)
         self.nodes[0].start()
diff --git a/test/functional/interface_bitcoin_cli.py b/test/functional/interface_bitcoin_cli.py
@@ -36,6 +36,8 @@ def set_test_params(self):
 
     def skip_test_if_missing_module(self):
         self.skip_if_no_cli()
+        # TODO: drop it when bitcoin#20267 is done
+        self.skip_if_no_bdb()
 
     def run_test(self):
         """Main test logic"""
diff --git a/test/functional/test_framework/test_framework.py b/test/functional/test_framework/test_framework.py
@@ -952,6 +952,8 @@ def skip_if_no_wallet(self):
             raise SkipTest("wallet has not been compiled.")
         if self.options.descriptors:
             self.skip_if_no_sqlite()
+        else:
+            self.skip_if_no_bdb()
 
     def skip_if_no_sqlite(self):
         """Skip the running test if sqlite has not been compiled."""
diff --git a/test/functional/wallet_descriptor.py b/test/functional/wallet_descriptor.py
@@ -20,6 +20,8 @@ def set_test_params(self):
 
     def skip_test_if_missing_module(self):
         self.skip_if_no_wallet()
+        # TODO: drop it when bitcoin#20267 is done
+        self.skip_if_no_bdb()
         self.skip_if_no_sqlite()
 
     def run_test(self):
