net: use std::deque for vSendMsg instead of std::list

kwvg · kwvg · commit caaa0fda01c2 · 2024-09-04T16:29:30.000Z
The change was introduced as an optimization in 027a852 (dash#3398) but prevents the backport of bitcoin#26844 due to the inability to engage in binary expressions with iterators of `std::list`.
diff --git a/src/net.h b/src/net.h
@@ -471,7 +471,7 @@ class CNode
     /** Offset inside the first vSendMsg already sent */
     size_t nSendOffset GUARDED_BY(cs_vSend){0};
     uint64_t nSendBytes GUARDED_BY(cs_vSend){0};
-    std::list<std::vector<unsigned char>> vSendMsg GUARDED_BY(cs_vSend);
+    std::deque<std::vector<unsigned char>> vSendMsg GUARDED_BY(cs_vSend);
     std::atomic<size_t> nSendMsgSize{0};
     Mutex cs_vSend;
     Mutex m_sock_mutex;
