chore: apply review suggestions

kwvg · kwvg · commit c7b5e7da5fb7 · 2025-12-31T16:42:04.000+05:30
diff --git a/src/llmq/quorums.cpp b/src/llmq/quorums.cpp
@@ -26,7 +26,7 @@ uint256 MakeQuorumKey(const CQuorum& q)
     return hw.GetHash();
 }
 
-void DataCleanupHelper(CDBWrapper& db, std::set<uint256> skip_list, bool compact)
+void DataCleanupHelper(CDBWrapper& db, const std::set<uint256>& skip_list, bool compact)
 {
     const auto prefixes = {DB_QUORUM_QUORUM_VVEC, DB_QUORUM_SK_SHARE};
 
diff --git a/src/llmq/quorums.h b/src/llmq/quorums.h
@@ -17,6 +17,7 @@
 #include <uint256.h>
 #include <util/time.h>
 
+#include <set>
 #include <string>
 #include <vector>
 
@@ -34,7 +35,7 @@ extern const std::string DB_QUORUM_SK_SHARE;
 extern const std::string DB_QUORUM_QUORUM_VVEC;
 
 uint256 MakeQuorumKey(const CQuorum& q);
-void DataCleanupHelper(CDBWrapper& db, std::set<uint256> skip_list, bool compact = false);
+void DataCleanupHelper(CDBWrapper& db, const std::set<uint256>& skip_list, bool compact = false);
 
 /**
  * Object used as a key to store CQuorumDataRequest
diff --git a/src/llmq/quorumsman.cpp b/src/llmq/quorumsman.cpp
@@ -521,7 +521,7 @@ MessageProcessingResult CQuorumManager::ProcessMessage(CNode& pfrom, CConnman& c
         }
 
         if (request.GetError() != CQuorumDataRequest::Errors::NONE) {
-            LogPrint(BCLog::LLMQ, "CQuorumManager::%s -- %s: %s, from peer=%d\n", __func__, msg_type, strprintf("Error %d (%s)", request.GetError(), request.GetErrorString()), pfrom.GetId());
+            LogPrint(BCLog::LLMQ, "CQuorumManager::%s -- %s: Error %d (%s), from peer=%d\n", __func__, msg_type, request.GetError(), request.GetErrorString(), pfrom.GetId());
             return {};
         }
 

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ uint256 MakeQuorumKey(const CQuorum& q)`
`26`	`26`	`return hw.GetHash();`
`27`	`27`	`}`
`28`	`28`
`29`		`-void DataCleanupHelper(CDBWrapper& db, std::set<uint256> skip_list, bool compact)`
	`29`	`+void DataCleanupHelper(CDBWrapper& db, const std::set<uint256>& skip_list, bool compact)`
`30`	`30`	`{`
`31`	`31`	`const auto prefixes = {DB_QUORUM_QUORUM_VVEC, DB_QUORUM_SK_SHARE};`
`32`	`32`
Original file line number	Diff line number	Diff line change
`@@ -521,7 +521,7 @@ MessageProcessingResult CQuorumManager::ProcessMessage(CNode& pfrom, CConnman& c`
`521`	`521`	`}`
`522`	`522`
`523`	`523`	`if (request.GetError() != CQuorumDataRequest::Errors::NONE) {`
`524`		`- LogPrint(BCLog::LLMQ, "CQuorumManager::%s -- %s: %s, from peer=%d\n", __func__, msg_type, strprintf("Error %d (%s)", request.GetError(), request.GetErrorString()), pfrom.GetId());`
	`524`	`+ LogPrint(BCLog::LLMQ, "CQuorumManager::%s -- %s: Error %d (%s), from peer=%d\n", __func__, msg_type, request.GetError(), request.GetErrorString(), pfrom.GetId());`
`525`	`525`	`return {};`
`526`	`526`	`}`
`527`	`527`