chore: remove scaffolding (SEM must be correct, no graceful fallback)

kwvg · kwvg · commit aca5ec9baaa0 · 2025-07-08T10:11:48.000Z
Graceful fallback was necessary when filling in the gaps functionality
wise but now that everything is in place, we should revert back to the
old behavior of crashing when supplied an invalid or inapplicable
SocketEventsMode preference as this means we didn't filter out an
invalid input from the user-end or didn't set our defaults correctly,
which is a logic error.
diff --git a/src/util/sock.cpp b/src/util/sock.cpp
@@ -180,49 +180,27 @@ bool Sock::WaitMany(std::chrono::milliseconds timeout, EventsPerSock& events_per
 
 bool Sock::WaitManyInternal(std::chrono::milliseconds timeout, EventsPerSock& events_per_sock, SocketEventsParams event_params)
 {
-    std::string debug_str;
-
     switch (event_params.m_event_mode)
     {
-        case SocketEventsMode::Poll:
 #ifdef USE_POLL
+        case SocketEventsMode::Poll:
             return WaitManyPoll(timeout, events_per_sock, event_params.m_wrap_func);
-#else
-            debug_str += "Sock::Wait -- Support for poll not compiled in, falling back on ";
-            break;
 #endif /* USE_POLL */
         case SocketEventsMode::Select:
             return WaitManySelect(timeout, events_per_sock, event_params.m_wrap_func);
-        case SocketEventsMode::EPoll:
 #ifdef USE_EPOLL
+        case SocketEventsMode::EPoll:
             assert(event_params.m_event_fd != INVALID_SOCKET);
             return WaitManyEPoll(timeout, events_per_sock, event_params.m_event_fd, event_params.m_wrap_func);
-#else
-            debug_str += "Sock::Wait -- Support for epoll not compiled in, falling back on ";
-            break;
 #endif /* USE_EPOLL */
-        case SocketEventsMode::KQueue:
 #ifdef USE_KQUEUE
+        case SocketEventsMode::KQueue:
             assert(event_params.m_event_fd != INVALID_SOCKET);
             return WaitManyKQueue(timeout, events_per_sock, event_params.m_event_fd, event_params.m_wrap_func);
-#else
-            debug_str += "Sock::Wait -- Support for kqueue not compiled in, falling back on ";
-            break;
 #endif /* USE_KQUEUE */
         default:
             assert(false);
     }
-#ifdef USE_POLL
-    debug_str += "poll";
-#else
-    debug_str += "select";
-#endif /* USE_POLL*/
-    LogPrint(BCLog::NET, "%s\n", debug_str);
-#ifdef USE_POLL
-    return WaitManyPoll(timeout, events_per_sock, event_params.m_wrap_func);
-#else
-    return WaitManySelect(timeout, events_per_sock, event_params.m_wrap_func);
-#endif /* USE_POLL */
 }
 
 #ifdef USE_EPOLL
