test: Always test the existence of secretKeyShare in test_mn_quorum_data

xdustinface · xdustinface · commit 92127d26d8fd · 2021-01-29T03:48:54.000+01:00
With this change it also validates that "secretKeyShare" is not in `quorum_info` if its not expected to be in there. Before this was basically just not tested.
diff --git a/test/functional/test_framework/test_framework.py b/test/functional/test_framework/test_framework.py
@@ -1090,8 +1090,8 @@ def get_mninfo(self, proTxHash):
         return None
 
     def test_mn_quorum_data(self, test_mn, quorum_type_in, quorum_hash_in, expect_secret=True):
-        quorum_info = test_mn.node.quorum("info", quorum_type_in, quorum_hash_in, expect_secret)
-        if expect_secret and "secretKeyShare" not in quorum_info:
+        quorum_info = test_mn.node.quorum("info", quorum_type_in, quorum_hash_in, True)
+        if expect_secret != ("secretKeyShare" in quorum_info):
             return False
         if "members" not in quorum_info or len(quorum_info["members"]) == 0:
             return False
