chore: remove unused IsInvInFilter from PeerManager interface

kwvg · kwvg · commit 7375aeac439d · 2025-08-15T10:29:50.000Z
dash#6425 moved AskNodesForLockedTx to PeerManager as
AskPeersForTransaction, which removed the only usage of IsInvInFilter.
We can safely remove it from the PeerManager interface as its usage is
now purely internal.
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
@@ -645,7 +645,6 @@ class PeerManagerImpl final : public PeerManager
     void RequestObject(NodeId nodeid, const CInv& inv, std::chrono::microseconds current_time,
                        bool is_masternode, bool fForce = false) override EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
     size_t GetRequestedObjectCount(NodeId nodeid) const override EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
-    bool IsInvInFilter(NodeId nodeid, const uint256& hash) const override EXCLUSIVE_LOCKS_REQUIRED(!m_peer_mutex);
     void AskPeersForTransaction(const uint256& txid, bool is_masternode) override EXCLUSIVE_LOCKS_REQUIRED(!m_peer_mutex);
 private:
     void _RelayTransaction(const uint256& txid) EXCLUSIVE_LOCKS_REQUIRED(cs_main);
@@ -2317,14 +2316,6 @@ void PeerManagerImpl::AskPeersForTransaction(const uint256& txid, bool is_master
     }
 }
 
-bool PeerManagerImpl::IsInvInFilter(NodeId nodeid, const uint256& hash) const
-{
-    PeerRef peer = GetPeerRef(nodeid);
-    if (peer == nullptr)
-        return false;
-    return IsInvInFilter(*peer, hash);
-}
-
 bool PeerManagerImpl::IsInvInFilter(const Peer& peer, const uint256& hash) const
 {
     if (auto tx_relay = peer.GetTxRelay(); tx_relay != nullptr) {
diff --git a/src/net_processing.h b/src/net_processing.h
@@ -85,9 +85,6 @@ class PeerManager : public CValidationInterface, public NetEventsInterface
     /** Send ping message to all peers */
     virtual void SendPings() = 0;
 
-    /** Is an inventory in the known inventory filter. Used by InstantSend. */
-    virtual bool IsInvInFilter(NodeId nodeid, const uint256& hash) const = 0;
-
     /** Ask a number of our peers, which have a transaction in their inventory, for the transaction. */
     virtual void AskPeersForTransaction(const uint256& txid, bool is_masternode) = 0;
 
