fix: revert "drop circular dependencies over deterministicmns in validationinterface"

kwvg · kwvg · commit 419a8af27435 · 2024-03-21T12:24:38.000Z
This reverts commit fa6847d.
diff --git a/src/validationinterface.cpp b/src/validationinterface.cpp
@@ -12,6 +12,7 @@
 #include <primitives/block.h>
 #include <primitives/transaction.h>
 #include <scheduler.h>
+#include <evo/deterministicmns.h>
 #include <governance/vote.h>
 #include <llmq/clsig.h>
 #include <llmq/signing.h>
@@ -288,7 +289,7 @@ void CMainSignals::NotifyChainLock(const CBlockIndex* pindex, const std::shared_
 }
 
 void CMainSignals::NotifyGovernanceVote(const CDeterministicMNList& tip_mn_list, const std::shared_ptr<const CGovernanceVote>& vote) {
-    auto event = [vote, &tip_mn_list, this] {
+    auto event = [vote, tip_mn_list, this] {
         m_internals->Iterate([&](CValidationInterface& callbacks) { callbacks.NotifyGovernanceVote(tip_mn_list, vote); });
     };
     ENQUEUE_AND_LOG_EVENT(event, "%s: notify governance vote: %s", __func__, vote->GetHash().ToString());
diff --git a/test/lint/lint-circular-dependencies.sh b/test/lint/lint-circular-dependencies.sh
@@ -98,6 +98,7 @@ EXPECTED_CIRCULAR_DEPENDENCIES=(
     "evo/mnhftx -> validation -> evo/mnhftx"
     "evo/deterministicmns -> validation -> evo/deterministicmns"
     "evo/chainhelper -> masternode/payments -> validation -> evo/chainhelper"
+    "evo/deterministicmns -> validationinterface -> evo/deterministicmns"
 )
 
 EXIT_CODE=0

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,7 @@ EXPECTED_CIRCULAR_DEPENDENCIES=(`
`98`	`98`	`"evo/mnhftx -> validation -> evo/mnhftx"`
`99`	`99`	`"evo/deterministicmns -> validation -> evo/deterministicmns"`
`100`	`100`	`"evo/chainhelper -> masternode/payments -> validation -> evo/chainhelper"`
	`101`	`+ "evo/deterministicmns -> validationinterface -> evo/deterministicmns"`
`101`	`102`	`)`
`102`	`103`
`103`	`104`	`EXIT_CODE=0`