fix: intermittent error in feature_notification due to extra CL

knst · knst · commit 21e6a4e85c3b · 2025-05-16T21:16:17.000+07:00
It can happen if the best block get CL too fast
diff --git a/test/functional/feature_notifications.py b/test/functional/feature_notifications.py
@@ -109,10 +109,15 @@ def run_test(self):
 
         self.log.info("Mine single block, wait for chainlock")
         self.bump_mocktime(1)
+        pre_tip = self.nodes[0].getbestblockhash()
         tip = self.generate(self.nodes[0], 1, sync_fun=self.no_op)[-1]
         self.wait_for_chainlocked_block_all_nodes(tip)
         # directory content should equal the chainlocked block hash
-        assert_equal([tip], sorted(os.listdir(self.chainlocknotify_dir)))
+        cl_hashes = sorted(os.listdir(self.chainlocknotify_dir))
+        if len(cl_hashes) <= 1:
+            assert_equal([tip], cl_hashes)
+        else:
+            assert_equal(sorted([tip, pre_tip]), cl_hashes)
 
         if self.is_wallet_compiled():
             self.log.info("test -instantsendnotify")
