boost: drop boost threads for [alert|block|wallet]notify

theuni · theuni · commit 004f9999464c · 2018-02-08T14:35:29.000-05:00
diff --git a/src/init.cpp b/src/init.cpp
@@ -546,7 +546,8 @@ static void BlockNotifyCallback(bool initialSync, const CBlockIndex *pBlockIndex
     std::string strCmd = gArgs.GetArg("-blocknotify", "");
     if (!strCmd.empty()) {
         boost::replace_all(strCmd, "%s", pBlockIndex->GetBlockHash().GetHex());
-        boost::thread t(runCommand, strCmd); // thread runs free
+        std::thread t(runCommand, strCmd);
+        t.detach(); // thread runs free
     }
 }
 
diff --git a/src/validation.cpp b/src/validation.cpp
@@ -1188,7 +1188,8 @@ static void AlertNotify(const std::string& strMessage)
     safeStatus = singleQuote+safeStatus+singleQuote;
     boost::replace_all(strCmd, "%s", safeStatus);
 
-    boost::thread t(runCommand, strCmd); // thread runs free
+    std::thread t(runCommand, strCmd);
+    t.detach(); // thread runs free
 }
 
 static void CheckForkWarningConditions()
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -34,7 +34,6 @@
 #include <future>
 
 #include <boost/algorithm/string/replace.hpp>
-#include <boost/thread.hpp>
 
 std::vector<CWalletRef> vpwallets;
 /** Transaction fee set by the user */
@@ -976,7 +975,8 @@ bool CWallet::AddToWallet(const CWalletTx& wtxIn, bool fFlushOnClose)
     if (!strCmd.empty())
     {
         boost::replace_all(strCmd, "%s", wtxIn.GetHash().GetHex());
-        boost::thread t(runCommand, strCmd); // thread runs free
+        std::thread t(runCommand, strCmd);
+        t.detach(); // thread runs free
     }
 
     return true;

Original file line number	Diff line number	Diff line change
`@@ -546,7 +546,8 @@ static void BlockNotifyCallback(bool initialSync, const CBlockIndex *pBlockIndex`
`546`	`546`	`std::string strCmd = gArgs.GetArg("-blocknotify", "");`
`547`	`547`	`if (!strCmd.empty()) {`
`548`	`548`	`boost::replace_all(strCmd, "%s", pBlockIndex->GetBlockHash().GetHex());`
`549`		`- boost::thread t(runCommand, strCmd); // thread runs free`
	`549`	`+ std::thread t(runCommand, strCmd);`
	`550`	`+ t.detach(); // thread runs free`
`550`	`551`	`}`
`551`	`552`	`}`
`552`	`553`
Original file line number	Diff line number	Diff line change
`@@ -1188,7 +1188,8 @@ static void AlertNotify(const std::string& strMessage)`
`1188`	`1188`	`safeStatus = singleQuote+safeStatus+singleQuote;`
`1189`	`1189`	`boost::replace_all(strCmd, "%s", safeStatus);`
`1190`	`1190`
`1191`		`- boost::thread t(runCommand, strCmd); // thread runs free`
	`1191`	`+ std::thread t(runCommand, strCmd);`
	`1192`	`+ t.detach(); // thread runs free`
`1192`	`1193`	`}`
`1193`	`1194`
`1194`	`1195`	`static void CheckForkWarningConditions()`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@`
`34`	`34`	`#include <future>`
`35`	`35`
`36`	`36`	`#include <boost/algorithm/string/replace.hpp>`
`37`		`-#include <boost/thread.hpp>`
`38`	`37`
`39`	`38`	`std::vector<CWalletRef> vpwallets;`
`40`	`39`	`/** Transaction fee set by the user */`
`@@ -976,7 +975,8 @@ bool CWallet::AddToWallet(const CWalletTx& wtxIn, bool fFlushOnClose)`
`976`	`975`	`if (!strCmd.empty())`
`977`	`976`	`{`
`978`	`977`	`boost::replace_all(strCmd, "%s", wtxIn.GetHash().GetHex());`
`979`		`- boost::thread t(runCommand, strCmd); // thread runs free`
	`978`	`+ std::thread t(runCommand, strCmd);`
	`979`	`+ t.detach(); // thread runs free`
`980`	`980`	`}`
`981`	`981`
`982`	`982`	`return true;`