fix: filter on pnpm-workspace.yaml (pnpm#10127)

KSXGitHub · zkochan · commit 6eedf828b4e4 · 2026-03-07T23:02:51.000+01:00
* fix: `filter` on `pnpm-workspace.yaml`

* docs: changeset

* fix: actual fix

* fix: don't set default on config
diff --git a/.changeset/strong-readers-think.md b/.changeset/strong-readers-think.md
@@ -0,0 +1,6 @@
+---
+"@pnpm/config": patch
+"pnpm": patch
+---
+
+Fix a bug in which specifying `filter` on `pnpm-workspace.yaml` would cause pnpm to not detect any projects.
diff --git a/config/config/src/index.ts b/config/config/src/index.ts
@@ -367,7 +367,7 @@ export async function getConfig (opts: {
     if (pnpmConfig.workspaceDir != null) {
       const workspaceManifest = await readWorkspaceManifest(pnpmConfig.workspaceDir)
 
-      pnpmConfig.workspacePackagePatterns = cliOptions['workspace-packages'] as string[] ?? workspaceManifest?.packages ?? ['.']
+      pnpmConfig.workspacePackagePatterns = cliOptions['workspace-packages'] as string[] ?? workspaceManifest?.packages
       if (workspaceManifest) {
         const newSettings = Object.assign(getOptionsFromPnpmSettings(pnpmConfig.workspaceDir, workspaceManifest, pnpmConfig.rootProjectManifest), configFromCliOpts)
         for (const [key, value] of Object.entries(newSettings)) {
diff --git a/pnpm/test/recursive/misc.ts b/pnpm/test/recursive/misc.ts
@@ -314,7 +314,9 @@ test('recursive command with filter from config', async () => {
   ])
 
   fs.writeFileSync('package.json', '{}', 'utf8')
-  fs.writeFileSync('.npmrc', 'filter=project-1 project-2', 'utf8')
+  writeYamlFile('pnpm-workspace.yaml', {
+    filter: ['project-1', 'project-2'],
+  })
   await execPnpm(['recursive', 'install'])
 
   projects['project-1'].has('is-positive')
