[WIP] Expose minimal API for flutter_tools consumption #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Jun 12, 2019
Contributor
Author
|
Re-using this to discuss some ideas with the API structure |
jonahwilliams
commented
Jun 13, 2019
webdev/lib/webdev.dart
Outdated
| export 'src/serve/debugger/app_debug_services.dart' show AppDebugServices; | ||
| export 'src/serve/debugger/devtools.dart' show DevTools; | ||
|
|
||
| Future<WebDevHandler> connectToWebdev( |
Contributor
Author
There was a problem hiding this comment.
This is the first stab at a basic API - I tried to expose as little as possible - really only the configuration needed to initialize the server and the interfaces we use to get the vm service or debug. See https://github.com/flutter/flutter/pull/34252/files#diff-01a7653ade6cc1a5182fdebf929ad64bR291 for example usage
jakemac53
reviewed
Jun 13, 2019
jonahwilliams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows flutter tools to inject its own serving logic for certain assets.