Support custom hostname and TLS options#2588
Conversation
|
@bkonyi Hi, I reformatted the code. Should I update the dwds/CHANGELOG.md file too?
|
Nope, I can disable that check for you! Overall this looks good to me, but ideally we'd add a test to make sure we don't regress in the future. Is that something you'd be willing to do? |
Hi @bkonyi, I added the tests. |
|
Fixed recent merge conflicts in the |
|
Will this be shipped in the next release? |
bkonyi
left a comment
bkonyi
left a comment
There was a problem hiding this comment.
Thank you for adding tests! Just a few comments.
Yes, this will be shipped with the next release of |
Awesome! I applied the requested changes, thanks for the suggestions! |
|
More than one month later, it seems to me no release has been made. Any chance of this happening soon? This bugfix is very important for me personally. |
|
Sorry for the delay @Wdestroier, this fell off my radar. LGTM! @nandoflorestan, once this lands @jyameo can publish a new version hopefully today or tomorrow. |
|
@Wdestroier can you please run |
|
Done @jyameo! |
Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/7a80178..af37fe5): af37fe54 2025-04-04 Lasse R.H. Nielsen Adds `[Heap]PriorityQueue.of` constructor. (dart-lang/core#734) 635dfa32 2025-04-03 Kevin Moore [collection] explicitly make BoolList abstract interface (dart-lang/core#875) ecosystem (https://github.com/dart-lang/ecosystem/compare/391a80c..7f6f1c1): 7f6f1c1 2025-04-09 Daco Harkes [firehose] Fix dart_apitool invocations with pub workspaces (dart-lang/ecosystem#355) 0eb0349 2025-04-07 Moritz Fix tagging in publishing workflow (again) (dart-lang/ecosystem#353) 1ee8568 2025-04-07 Moritz Update README.md (dart-lang/ecosystem#352) http (https://github.com/dart-lang/http/compare/6fabf06..e4ddd3e): e4ddd3e 2025-04-07 Moritz Merge pull request `#1750` from dart-lang/fixTags 42b42e3 2025-04-07 Moritz Fix tags 54bf0f7 2025-04-07 Moritz Merge pull request `#1748` from dart-lang/fixPublish 84adca0 2025-04-04 Moritz Merge pull request `#1432` from dart-lang/fixHealth 8534a69 2025-04-04 Moritz Remove ignore breaking b80436a 2025-04-04 Moritz allow underscore 949cd87 2025-04-04 Moritz Fix publishing workflow 996c5d1 2024-12-17 Moritz ignore only for breaking changes e5321f7 2024-12-17 Moritz Update .github/workflows/health.yaml f902d8a 2024-12-17 Moritz typo 35f6e9a 2024-12-17 Moritz exclude websocket ca8caee 2024-12-17 Moritz Ignore http 621401e 2024-12-17 Moritz remove ignore license ce20b2a 2024-12-17 Moritz Fix health workflow test (https://github.com/dart-lang/test/compare/c1fa1e6..8643fbf): 8643fbf3 2025-04-09 Ömer Sinan Ağacan Migrate from deprecated `dart:js`, `dart:js_util`, `package:js_util` to `dart:js_interop` (dart-lang/test#2478) tools (https://github.com/dart-lang/tools/compare/b963bbf..d74f9e1): d74f9e13 2025-04-08 Loïc Sharma [UA] Add a Flutter event for plugins injected into an iOS/macOS project. (dart-lang/tools#2062) f34228f8 2025-04-08 Kevin Moore [graphs] fix readme CI badge (dart-lang/tools#2068) 0102cd63 2025-04-08 Kevin Moore [markdown] fix crash test (dart-lang/tools#2067) webdev (https://github.com/dart-lang/webdev/compare/697f2f7..c8b1cfa): c8b1cfa9 2025-04-07 Srujan Gaddam [dwds] Split hot reload callback into 2, disable breakpoints in changed files, and publish 24.3.10 (dart-lang/webdev#2606) 8d8413f5 2025-04-04 Wdestroier Support custom hostname and TLS options (dart-lang/webdev#2588) Change-Id: Idbad02c2087ceb3c7d0f7efcf0721f4806475e8e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/421542 Reviewed-by: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
4 participants
Fixes #953.