Repository navigation
Do not persist breakpoints across hot restarts or page refreshes - #2371
Merged
Merged
Conversation
elliette
changed the title
setBreakpoints instead of setBreakpointsByUrl
16 tasks done
Contributor
Author
|
Submitting with failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2257
setBreakpointinstead ofsetBreakpointByUrl. When breakpoints are set with thesetBreakpointAPI, Chrome will not try to persist breakpoints across page reloads. This was causing an issue where Chrome might still be hanging onto a breakpoint that didn't exist in the debugging client.See go/dart-web-phantom-breakpoints for more details