Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
404 changes: 185 additions & 219 deletions .github/workflows/dart.yml

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 16.0.2
- Don't complete an already completed `Completer` in `ChromeProxyService` to fix
Flutter tools crash: https://github.com/dart-lang/webdev/pull/1862

## 16.0.1

- Allow the following API to return `null` and add error handling:
Expand Down
110 changes: 58 additions & 52 deletions dwds/lib/src/injected/client.js

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion dwds/lib/src/services/chrome_proxy_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,13 @@ class ChromeProxyService implements VmServiceInterface {

unawaited(appConnection.onStart.then((_) async {
await debugger.resumeFromStart();
_startedCompleter.complete();
if (!_startedCompleter.isCompleted) {
_startedCompleter.complete();
} else {
// See https://github.com/flutter/flutter/issues/117676:
_logger
.warning('Unexpected state, debugging may not work as expected.');
}
}));

unawaited(appConnection.onDone.then((_) => destroyIsolate()));
Expand Down
2 changes: 1 addition & 1 deletion dwds/lib/src/version.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions dwds/mono_pkg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@ stages:
- command: Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
- test:
sdk:
- dev
- stable
- test:
os: windows
sdk:
- dev
- stable
- beta_cron:
- analyze: .
Expand Down
2 changes: 1 addition & 1 deletion dwds/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: dwds
# Every time this changes you need to run `dart run build_runner build`.
version: 16.0.1
version: 16.0.2
description: >-
A service that proxies between the Chrome debug protocol and the Dart VM
service protocol.
Expand Down
2 changes: 1 addition & 1 deletion tool/ci.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.