Skip to content

Set breakpoints by regex URL - #1078

Merged
grouma merged 6 commits into
masterfrom
breakpoints
Aug 3, 2020
Merged

Set breakpoints by regex URL#1078
grouma merged 6 commits into
masterfrom
breakpoints

Conversation

@grouma

@grouma grouma commented Jul 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Member
  • Use setBreakpointsByUrl to set breakpoints using a regex based on the module path
  • Chrome now handles re-establishing breakpoints upon refresh so remove the corresponding deprecated argument

Closes #1076

@grouma grouma changed the title [WIP] Set breakpoints by regex URL Set breakpoints by regex URL Jul 31, 2020
@grouma grouma mentioned this pull request Jul 31, 2020
Open
@grouma
grouma requested review from annagrin and devoncarew July 31, 2020 16:14
@devoncarew

devoncarew commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

Chrome now handles re-establishing breakpoints upon restart

fyi for @bkonyi - package:dwds will attempt to auto-restore breakpoints after a hot restart; we'll want to coordinate this with DDS, so clients can know when auto-restore happens

@grouma

grouma commented Aug 3, 2020

Copy link
Copy Markdown
Member Author

fyi for @bkonyi - package:dwds will attempt to auto-restore breakpoints after a hot restart; we'll want to coordinate this with DDS, so clients can know when auto-restore happens

Yeah I was thinking through this a bit more. An alternative is to simply delete the breakpoints upon reload and manually add them back much like we do during a hot reload. We'll still want to use the updated setBreakpointByUrl API. I don't have a strong preference so I intend to leave it as is for now.

cc @jonahwilliams in case he may have concerns

@grouma

grouma commented Aug 3, 2020

Copy link
Copy Markdown
Member Author

Merging with a Windows flake.

@grouma
grouma merged commit ebad718 into master Aug 3, 2020
@grouma
grouma deleted the breakpoints branch August 3, 2020 16:21
@elliette elliette mentioned this pull request Jul 6, 2023
Closed
@elliette elliette mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annagrin annagrin Awaiting requested review from annagrin
1 more reviewer
@devoncarew devoncarew devoncarew approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate to Debugger.setBreakpointByUrl

2 participants

@grouma @devoncarew