Add support for accessing CSS properties directly from JS. #48
Conversation
|
@srujzs @sigmundch ptal. I'm not sure if we really want to expose the webkit properties in this manner. I'm happy to hide those if we don't think they are useful. |
|
Cool! I'd probably default to dropping the browser-specific ones. Unless we get individual requests. |
done. |
| final array = objectEntries(await promiseToFuture<JSObject>(css.listAll())); | ||
| for (var i = 0; i < array.length.toDart; i++) { | ||
| final entry = array[i.toJS] as JSArray; | ||
| final data = entry[1.toJS] as JSObject; |
There was a problem hiding this comment.
not necessarily actionable right now: all these index accesses feel very cumbersome, I think we will want to continue iterating on how to improve the experience here.
My default at the moment would be to create a proxy to wrap the array, use regular iteration, and use a Dart int indices.
There was a problem hiding this comment.
Yea, we definitely want to do something better here.
As you suggest, for places where performance isn't a concern, then an adapter class seems like a good choice.
We can provide such helper adapters, perhaps we can even avoid reifying the adapters on JS backends.
3 participants
Fixes #47