Skip to content

[extension_discovery] Fix reliablyRename always throwing after rename on Windows - #2726

Merged
jonasfj merged 2 commits into
mainfrom
fix_issue_2681
Oct 27, 2026
Merged

[extension_discovery] Fix reliablyRename always throwing after rename on Windows#2726
jonasfj merged 2 commits into
mainfrom
fix_issue_2681

Conversation

@jonasfj

@jonasfj jonasfj commented Oct 27, 2026

Copy link
Copy Markdown
Member

Return await fn() inside the retry loop in _attempt so it does not run fn() a second time on Windows after a successful call.

Fixes #2681

@jonasfj
jonasfj requested review from a team as code owners October 27, 2026 10:44
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 27, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in the _attempt helper function within pkgs/extension_discovery/lib/src/io.dart by adding a missing return statement when executing the provided function. This prevents the retry loop from running indefinitely on a successful execution, which previously caused reliablyRename on Windows to fail. A corresponding entry has also been added to the changelog. No review comments were provided, and there is no additional feedback.

@github-actions

github-actions Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
extension_discovery Non-Breaking 2.1.0 2.1.1-wip 2.1.1-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Coverage ✔️
File Coverage
pkgs/extension_discovery/lib/src/io.dart 💚 35 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check (for example, for non-user-visible changes when the package version is already at -wip).

License Headers ✔️ 
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/html/test/differential_test.dart
pkgs/html/test/dom_parsing_test.dart
pkgs/html/test/mxss_test.dart
pkgs/html/test/noah_ark_clause_limit_test.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Unused Dependencies ⚠️
Package Status
extension_discovery
❗ Show Issues
These packages are used outside lib/ but are not dev_dependencies:
  * hello_world

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

@jonasfj jonasfj mentioned this pull request Oct 27, 2026
Merged
@davidmorgan
davidmorgan self-requested a review October 27, 2026 10:46
@jonasfj
jonasfj merged commit eee87b1 into main Oct 27, 2026
21 checks passed
@jonasfj
jonasfj deleted the fix_issue_2681 branch October 27, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidmorgan davidmorgan davidmorgan approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package:extension_discovery

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[extension_discovery] reliablyRename always throws after a successful rename on Windows

2 participants

@jonasfj @davidmorgan