Skip to content

[html] fix: license updated - #2723

Closed
varindergroove wants to merge 1 commit into
dart-lang:mainfrom
varindergroove:main
Closed

varindergroove wants to merge 1 commit into
dart-lang:mainfrom
varindergroove:main

Conversation

@varindergroove

Copy link
Copy Markdown

Summary

Updated the LICENSE file in pkgs/html ([pkgs/html/LICENSE](file:///D:/AndroidStudioProjects/dart-tools/pkgs/html/LICENSE)) to use the standard MIT License format and clarify licensing terms.

Changes

  • Replaced custom copyright and contributor listing block with the standard The MIT License (MIT) boilerplate text.
  • Retained the original copyright holder notice (Copyright (c) 2006-2012 The Authors).

Motivation

  • Ensures clear, standardized licensing terminology across the package distribution.
  • Simplifies dependency compliance checking for consumers of the html package.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore / Documentation / Legal update

@varindergroove
varindergroove requested a review from a team as a code owner October 26, 2026 06:30
@google-cla

google-cla Bot commented Oct 26, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the LICENSE file in the pkgs/html directory to the standard MIT License format, removing the list of individual contributors. There are no review comments, and I have no feedback to provide.

@jonasfj

jonasfj commented Oct 26, 2026

Copy link
Copy Markdown
Member

I don't know if we can do this.

I've asked appropriate authority.

@varindergroove, feel free to give me a ping, if I don't follow up within the next 3 weeks or so, I think it might take some time to figure out if we can do something like this.

@varindergroove

Copy link
Copy Markdown
Author

Thank you for looking into this, @jonasfj

I made this change for security and compliance reasons because the package was showing an unknown license. I wanted to address this issue to ensure the package's license information is correctly identified and avoid potential security or compliance concerns.

I understand that this may require approval from the appropriate authority, and I appreciate you checking whether this change is possible. Please let me know if any additional information or clarification is needed from my side.

@jonasfj

jonasfj commented Oct 26, 2026

Copy link
Copy Markdown
Member

@varindergroove I see absolutely no security implications from this, either way.

I do see how this can easing automated license compliance.

@deepak-groove

Copy link
Copy Markdown
Screenshot 2026-10-27 at 11 32 35 AM

we required a valid SBOM report, and under that report, it shows a License Type : Unknown. This is a compliance point. so need a valid License on the package.

@jonasfj

jonasfj commented Oct 28, 2026

Copy link
Copy Markdown
Member

Closing in favor of #2733 which is very similar.

Thanks for the PR, I think #2733 will resolve your issue, and alleviate any concerns about removing copyright notices.

@jonasfj jonasfj closed this Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants